Issue 30693003: Test setting string properties to null on <audio>, <video>, <source> and <track>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 30693003: Test setting string properties to null on <audio>, <video>, <source> and <track> (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
jochen (gone - plz use gerrit), Mike West

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

Test setting string properties to null on <audio>, <video>, <source> and <track> http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html The spec doesn't have [TreatNullAs=NullString] for any of these properties, so the added tests are actually wrong for mediaGroup, poster and src. The implementation will be fixed in future commits. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160195

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -0 lines)			Patch
	M	LayoutTests/fast/dom/element-attribute-js-null.html	View		3 chunks	+38 lines, -0 lines	0 comments	Download
	M	LayoutTests/fast/dom/element-attribute-js-null-expected.txt	View		3 chunks	+18 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Mike West

LGTM. Can you point at the relevant bit of the specification in the CL description?

7 years, 1 month ago (2013-10-22 08:06:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/30693003/1

7 years, 1 month ago (2013-10-22 08:17:13 UTC) #3

Message was sent while issue was closed.

Change committed as 160195