Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 306923008: Add tracing to measure the entire time it takes to satisfy a getStats request. (Closed)

Created:
6 years, 6 months ago by tommi (sloooow) - chröme
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Add tracing to measure the entire time it takes to satisfy a getStats request. BUG=369796 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274220

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M content/renderer/media/rtc_peer_connection_handler.cc View 2 chunks +10 lines, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
tommi (sloooow) - chröme
6 years, 6 months ago (2014-05-30 16:23:15 UTC) #1
tommi (sloooow) - chröme
ping in case you missed this.
6 years, 6 months ago (2014-06-02 10:00:10 UTC) #2
no longer working on chromium
lgtm with one question, please remove the old trace event if it does not add ...
6 years, 6 months ago (2014-06-02 11:03:20 UTC) #3
tommi (sloooow) - chröme
https://codereview.chromium.org/306923008/diff/1/content/renderer/media/rtc_peer_connection_handler.cc File content/renderer/media/rtc_peer_connection_handler.cc (right): https://codereview.chromium.org/306923008/diff/1/content/renderer/media/rtc_peer_connection_handler.cc#newcode243 content/renderer/media/rtc_peer_connection_handler.cc:243: TRACE_EVENT0("webrtc", "StatsResponse::OnComplete") On 2014/06/02 11:03:21, xians1 wrote: > do ...
6 years, 6 months ago (2014-06-02 11:27:48 UTC) #4
tommi (sloooow) - chröme
The CQ bit was checked by tommi@chromium.org
6 years, 6 months ago (2014-06-02 11:27:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/306923008/1
6 years, 6 months ago (2014-06-02 11:28:47 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 13:12:17 UTC) #7
Message was sent while issue was closed.
Change committed as 274220

Powered by Google App Engine
This is Rietveld 408576698