Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 306923007: Reuse same browser for all pages in rasterize_and_record_micro (Closed)

Created:
6 years, 6 months ago by Sami
Modified:
6 years, 6 months ago
Reviewers:
tonyg, ernstm
CC:
chromium-reviews, telemetry+watch_chromium.org
Visibility:
Public.

Description

Reuse same browser for all pages in rasterize_and_record_micro Don't restart the browser between each tested page in rasterize_and_record_micro. This improves stability and -- somewhat surprisingly -- reduces noise in the results. As an added bonus the rasterize_and_record_micro.key_silk_cases test completes in about 9 min compared to an earlier 16 min. To measure the impact of the change I ran 18 rasterize_and_record_micro iterations for 19 pages in key_silk_cases on a Nexus 5 (strapped to a water bottle for cooling) and logged the per-page record_time results for each run. The results were: With browser restarts (baseline): - Average record time: 1.78 ms - Average record time standard deviation: 0.0978 Without browser restarts (patch): - Average record time: 1.63 ms - Average record time standard deviation: 0.0379 BUG=355952 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273984

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/measurements/rasterize_and_record_micro.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Sami
6 years, 6 months ago (2014-05-30 16:19:26 UTC) #1
tonyg
lgtm Woot! Are there other benchmarks that could benefit from the same?
6 years, 6 months ago (2014-05-30 16:36:30 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-05-30 16:36:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/306923007/1
6 years, 6 months ago (2014-05-30 16:39:26 UTC) #4
ernstm
On 2014/05/30 16:36:47, tonyg wrote: > The CQ bit was checked by mailto:tonyg@chromium.org That is ...
6 years, 6 months ago (2014-05-30 16:41:53 UTC) #5
Sami
Grep only tells me about 3 tests that do this: GPU context lost test, GPU ...
6 years, 6 months ago (2014-05-30 16:41:57 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 01:39:30 UTC) #7
Message was sent while issue was closed.
Change committed as 273984

Powered by Google App Engine
This is Rietveld 408576698