Issue 306923006: Use unsigned type for iteration to avoid int overflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306923006: Use unsigned type for iteration to avoid int overflow. (Closed)

Created:
6 years, 6 months ago by halyavin

Modified:
6 years, 6 months ago

Reviewers:
Bo Xu, jam

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

Use unsigned type for iteration to avoid int overflow. If src_len in PDF_DecodeText is larger than 2^31, 2 * max_chars will overflow and the function will produce an incorrect result. BUG=none R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/bb2b1e7

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	core/src/fpdfapi/fpdf_parser/fpdf_parser_decode.cpp	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

halyavin

On 2014/06/04 16:48:45, bo_xu wrote: > lgtm Can you commit this change for me, please?

6 years, 6 months ago (2014-06-04 18:34:57 UTC) #4

jam

6 years, 6 months ago (2014-06-04 23:04:40 UTC) #5

Message was sent while issue was closed.

On 2014/06/04 18:34:57, halyavin wrote:
> On 2014/06/04 16:48:45, bo_xu wrote:
> > lgtm
> 
> Can you commit this change for me, please?

done