Source/core/rendering/RenderDetailsMarker.cpp - Issue 306923003: Use webkit-margin-end for details element to get same margin for both ltr and rtl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderDetailsMarker.cpp

Issue 306923003: Use webkit-margin-end for details element to get same margin for both ltr and rtl (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: RenderDetailsMarker marker box to include margin right and left Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderDetailsMarker.cpp

diff --git a/Source/core/rendering/RenderDetailsMarker.cpp b/Source/core/rendering/RenderDetailsMarker.cpp

index 45b3b5da7980b1c5058e349c564a6fa70ba2e927..b4adb2f9461a86e88ba17f32dd9e7cd50359beec 100644

--- a/Source/core/rendering/RenderDetailsMarker.cpp

+++ b/Source/core/rendering/RenderDetailsMarker.cpp

@@ -132,7 +132,10 @@ void RenderDetailsMarker::paint(PaintInfo& paintInfo, const LayoutPoint& paintOf

paintInfo.context->setStrokeThickness(1.0f);

paintInfo.context->setFillColor(color);

- boxOrigin.move(borderLeft() + paddingLeft(), borderTop() + paddingTop());

+ if (style()->writingMode() == TopToBottomWritingMode || style()->writingMode() == BottomToTopWritingMode) // Horizontal mode

+ boxOrigin.move(borderLeft() + paddingLeft() + (style()->isLeftToRightDirection() ? marginLeft(): marginRight()), borderTop() + paddingTop());

+ else

+ boxOrigin.move(borderLeft() + paddingLeft(), borderTop() + paddingTop());

leviw_travelin_and_unemployed 2014/06/10 19:06:58 This seems wrong. Why do you only consider margin

paintInfo.context->fillPath(getPath(boxOrigin));

}

« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »