Use webkit-margin-end for details element to get same margin for both ltr and rtl

Source/core/rendering/InlineFlowBox.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 399 matching lines @@
                 logicalLeft += flow->marginLogicalLeft();
                 if (knownToHaveNoOverflow())
                     minLogicalLeft = min(logicalLeft, minLogicalLeft);
                 logicalLeft = flow->placeBoxesInInlineDirection(logicalLeft, needsWordSpacing, textBoxDataMap);
                 if (knownToHaveNoOverflow())
                     maxLogicalRight = max(logicalLeft, maxLogicalRight);
                 logicalLeft += flow->marginLogicalRight();
             } else if (!curr->renderer().isListMarker() || toRenderListMarker(curr->renderer()).isInside()) {
                 // The box can have a different writing-mode than the overall line, so this is a bit complicated.
                 // Just get all the physical margin and overflow values by hand based off |isVertical|.
+                TextDirection dir = renderer().style()->direction();
+                bool isDetailsMarker = curr->renderer().isDetailsMarker();
+
                 LayoutUnit logicalLeftMargin = isHorizontal() ? curr->boxModelObject()->marginLeft() : curr->boxModelObject()->marginTop();
                 LayoutUnit logicalRightMargin = isHorizontal() ? curr->boxModelObject()->marginRight() : curr->boxModelObject()->marginBottom();
 
-                logicalLeft += logicalLeftMargin;
+                if (isDetailsMarker)

[eseidel, 2014/05/30 00:33:25]

I don't understand why details markers are special in this code?  This feels
like the wrong layer to know about that kind of thing.

[Habib Virji, 2014/06/03 14:23:46]

@eseidel: RenderListItem::updateMarkerLocation
(https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...)
already calculates offset hence in placeBoxRangeInInlineDirection, I am omitting
list item and just calculating for details marker. If marginRight gets added it
leaves the list marker at wrong location. Do you reckon to have something
similar as updateMarkerLocation for details marker too? 

[leviw_travelin_and_unemployed, 2014/06/05 22:25:43]

I'd either expect the list and details code to be shared or the
RenderDetailsMaker code to handle this itself. I'm with Eric: This isn't the
right layer for this.

+                    logicalLeft += (dir == LTR) ? logicalLeftMargin : logicalRightMargin;
+                else
+                    logicalLeft += logicalLeftMargin;
                 curr->setLogicalLeft(logicalLeft);
                 if (knownToHaveNoOverflow())
                     minLogicalLeft = min(logicalLeft, minLogicalLeft);
                 logicalLeft += curr->logicalWidth();
                 if (knownToHaveNoOverflow())
                     maxLogicalRight = max(logicalLeft, maxLogicalRight);
-                logicalLeft += logicalRightMargin;
+                if (isDetailsMarker)
+                    logicalLeft += (dir == LTR) ? logicalRightMargin : logicalLeftMargin;
+                else
+                    logicalLeft += logicalRightMargin;
                 // If we encounter any space after this inline block then ensure it is treated as the space between two words.
                 needsWordSpacing = true;
             }
         }
     }
     return logicalLeft;
 }
 
 bool InlineFlowBox::requiresIdeographicBaseline(const GlyphOverflowAndFallbackFontsMap& textBoxDataMap) const
 {
@@ skipping 1215 matching lines @@
         ASSERT(child->prevOnLine() == prev);
         prev = child;
     }
     ASSERT(prev == m_lastChild);
 #endif
 }
 
 #endif
 
 } // namespace WebCore