Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 306903002: Link QUIC connection ID to events page in net-internals (Closed)

Created:
6 years, 6 months ago by Robbie Shade
Modified:
6 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, eroman, arv+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Improve chrome://net-internals/#quic by linking QUIC connection ID to chrome://net-internals/#events&q=connection_id BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273872

Patch Set 1 #

Patch Set 2 : Restrict query to type=QUIC_SESSION #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/net_internals/quic_view.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Robbie Shade
6 years, 6 months ago (2014-05-29 16:16:44 UTC) #1
eroman
The query seems a bit generic, have you considered adding restrictions on event type or ...
6 years, 6 months ago (2014-05-29 22:48:54 UTC) #2
Robbie Shade
On 2014/05/29 22:48:54, eroman wrote: > The query seems a bit generic, have you considered ...
6 years, 6 months ago (2014-05-30 13:34:58 UTC) #3
Robbie Shade
The CQ bit was checked by rjshade@google.com
6 years, 6 months ago (2014-05-30 13:35:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjshade@google.com/306903002/20001
6 years, 6 months ago (2014-05-30 13:36:30 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 15:22:01 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 15:22:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12237)
6 years, 6 months ago (2014-05-30 15:22:55 UTC) #8
Robbie Shade
The CQ bit was checked by rjshade@google.com
6 years, 6 months ago (2014-05-30 17:21:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjshade@google.com/306903002/20001
6 years, 6 months ago (2014-05-30 17:23:01 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 17:52:59 UTC) #11
Message was sent while issue was closed.
Change committed as 273872

Powered by Google App Engine
This is Rietveld 408576698