chrome_frame/chrome_launcher_unittest.cc - Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/chrome_launcher_unittest.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)

Patch Set: fix Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/chrome_launcher_unittest.cc

diff --git a/chrome_frame/chrome_launcher_unittest.cc b/chrome_frame/chrome_launcher_unittest.cc

index 9511b405b6503e88be35b1a4b3893bb9163b4cbe..3d233ac643f44121db7ed60a20de5e3e29ff3c27 100644

--- a/chrome_frame/chrome_launcher_unittest.cc

+++ b/chrome_frame/chrome_launcher_unittest.cc

@@ -20,7 +20,7 @@ TEST(ChromeLauncher, IsValidCommandLine) {

CommandLine good(FilePath(L"dummy.exe"));

good.AppendSwitch(switches::kNoFirstRun); // in whitelist

- good.AppendSwitchWithValue(switches::kUserDataDir, "foo"); // in whitelist

+ good.AppendSwitchASCII(switches::kUserDataDir, "foo"); // in whitelist

EXPECT_TRUE(chrome_launcher::IsValidCommandLine(

good.command_line_string().c_str()));