chrome/browser/net/chrome_url_request_context_unittest.cc - Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_url_request_context_unittest.cc

Issue 3069014: Convert a bunch of easy AppendSwitchWithValue to *ASCII. (Closed)

Patch Set: fix Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/nacl_host/nacl_process_host.cc ('k') | chrome/browser/plugin_process_host.cc » ('j') | chrome/browser/worker_host/worker_process_host.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_url_request_context_unittest.cc

diff --git a/chrome/browser/net/chrome_url_request_context_unittest.cc b/chrome/browser/net/chrome_url_request_context_unittest.cc

index 9f42e7bc6118318ece05edddefbb1de99d3c75cf..eaaddf598ce9ffbefc9c693f22585d90844cb9cd 100644

--- a/chrome/browser/net/chrome_url_request_context_unittest.cc

+++ b/chrome/browser/net/chrome_url_request_context_unittest.cc

@@ -24,24 +24,23 @@ TEST(ChromeURLRequestContextTest, CreateProxyConfigTest) {

no_proxy.AppendSwitch(switches::kNoProxyServer);

CommandLine no_proxy_extra_params(unused_path);

no_proxy_extra_params.AppendSwitch(switches::kNoProxyServer);

- no_proxy_extra_params.AppendSwitchWithValue(switches::kProxyServer,

- "http://proxy:8888");

+ no_proxy_extra_params.AppendSwitchASCII(switches::kProxyServer,

+ "http://proxy:8888");

CommandLine single_proxy(unused_path);

- single_proxy.AppendSwitchWithValue(switches::kProxyServer,

- "http://proxy:8888");

+ single_proxy.AppendSwitchASCII(switches::kProxyServer, "http://proxy:8888");

CommandLine per_scheme_proxy(unused_path);

- per_scheme_proxy.AppendSwitchWithValue(switches::kProxyServer,

- "http=httpproxy:8888;ftp=ftpproxy:8889");

+ per_scheme_proxy.AppendSwitchASCII(switches::kProxyServer,

+ "http=httpproxy:8888;ftp=ftpproxy:8889");

CommandLine per_scheme_proxy_bypass(unused_path);

- per_scheme_proxy_bypass.AppendSwitchWithValue(switches::kProxyServer,

+ per_scheme_proxy_bypass.AppendSwitchASCII(

+ switches::kProxyServer,

"http=httpproxy:8888;ftp=ftpproxy:8889");

- per_scheme_proxy_bypass.AppendSwitchWithValue(

+ per_scheme_proxy_bypass.AppendSwitchASCII(

switches::kProxyBypassList,

".google.com, foo.com:99, 1.2.3.4:22, 127.0.0.1/8");

CommandLine with_pac_url(unused_path);

- with_pac_url.AppendSwitchWithValue(switches::kProxyPacUrl,

- "http://wpad/wpad.dat");

- with_pac_url.AppendSwitchWithValue(

+ with_pac_url.AppendSwitchASCII(switches::kProxyPacUrl, "http://wpad/wpad.dat");

+ with_pac_url.AppendSwitchASCII(

switches::kProxyBypassList,

".google.com, foo.com:99, 1.2.3.4:22, 127.0.0.1/8");

CommandLine with_auto_detect(unused_path);