Issue 306893002: Use a data url in DidStopLoadingDetailsWithPending test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306893002: Use a data url in DidStopLoadingDetailsWithPending test. (Closed)

Created:
6 years, 6 months ago by mkosiba (inactive)

Modified:
6 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org, Charlie Reis

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use a data url in DidStopLoadingDetailsWithPending test. This is to make the test continue passing after http://crrev.com/181493007 lands. The test was relying on the renderer stopping all loaders when a new navigation is issued (which would result in a DidStopLoading callback). After the mentioned CL lands the renderer will not stop+restart loading when asked to navigate during a load breaking the test. The fix is to use a data URL which will result in a DidStopLoading immediately after the didCommitProvisionalLoad callback. Since the test is only checking whether the UI-side state is correct it doesn't matter that the DidStopLoading IPC is pending when didCommitProvisionalLoad is being received. BUG=325351 TEST=content_browsertests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273758