Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Side by Side Diff: Source/bindings/v8/ScriptDebugServer.cpp

Issue 306853002: Replace Context::Scope with ScriptState::Scope (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010-2011 Google Inc. All rights reserved. 2 * Copyright (c) 2010-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 currentCallFrameV8 = callDebuggerMethod("currentCallFrame", WTF_ARRAY_LE NGTH(argv), argv); 330 currentCallFrameV8 = callDebuggerMethod("currentCallFrame", WTF_ARRAY_LE NGTH(argv), argv);
331 } 331 }
332 ASSERT(!currentCallFrameV8.IsEmpty()); 332 ASSERT(!currentCallFrameV8.IsEmpty());
333 if (!currentCallFrameV8->IsObject()) 333 if (!currentCallFrameV8->IsObject())
334 return PassRefPtr<JavaScriptCallFrame>(); 334 return PassRefPtr<JavaScriptCallFrame>();
335 return JavaScriptCallFrame::create(v8::Debug::GetDebugContext(), v8::Handle< v8::Object>::Cast(currentCallFrameV8)); 335 return JavaScriptCallFrame::create(v8::Debug::GetDebugContext(), v8::Handle< v8::Object>::Cast(currentCallFrameV8));
336 } 336 }
337 337
338 ScriptValue ScriptDebugServer::currentCallFramesInner(ScopeInfoDetails scopeDeta ils) 338 ScriptValue ScriptDebugServer::currentCallFramesInner(ScopeInfoDetails scopeDeta ils)
339 { 339 {
340 v8::HandleScope scope(m_isolate); 340 v8::HandleScope handleScope(m_isolate);
341 v8::Handle<v8::Context> pausedContext = m_pausedContext.IsEmpty() ? m_isolat e->GetCurrentContext() : m_pausedContext; 341 v8::Handle<v8::Context> pausedContext = m_pausedContext.IsEmpty() ? m_isolat e->GetCurrentContext() : m_pausedContext;
adamk 2014/05/30 19:59:22 Should m_pausedContext be a ScriptState?
haraken 2014/06/02 01:14:50 Done.
342 if (pausedContext.IsEmpty()) 342 if (pausedContext.IsEmpty())
343 return ScriptValue(); 343 return ScriptValue();
344 344
345 RefPtr<JavaScriptCallFrame> currentCallFrame = wrapCallFrames(0, scopeDetail s); 345 RefPtr<JavaScriptCallFrame> currentCallFrame = wrapCallFrames(0, scopeDetail s);
346 if (!currentCallFrame) 346 if (!currentCallFrame)
347 return ScriptValue(); 347 return ScriptValue();
348 348
349 v8::Context::Scope contextScope(pausedContext); 349 ScriptState* scriptState = ScriptState::from(pausedContext);
350 return ScriptValue(ScriptState::from(pausedContext), toV8(currentCallFrame.r elease(), v8::Handle<v8::Object>(), pausedContext->GetIsolate())); 350 ScriptState::Scope scope(scriptState);
351 return ScriptValue(scriptState, toV8(currentCallFrame.release(), scriptState ->context()->Global(), pausedContext->GetIsolate()));
351 } 352 }
352 353
353 ScriptValue ScriptDebugServer::currentCallFrames() 354 ScriptValue ScriptDebugServer::currentCallFrames()
354 { 355 {
355 return currentCallFramesInner(AllScopes); 356 return currentCallFramesInner(AllScopes);
356 } 357 }
357 358
358 ScriptValue ScriptDebugServer::currentCallFramesForAsyncStack() 359 ScriptValue ScriptDebugServer::currentCallFramesForAsyncStack()
359 { 360 {
360 return currentCallFramesInner(FastAsyncScopes); 361 return currentCallFramesInner(FastAsyncScopes);
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
618 { 619 {
619 return PassOwnPtr<ScriptSourceCode>(); 620 return PassOwnPtr<ScriptSourceCode>();
620 } 621 }
621 622
622 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName) 623 String ScriptDebugServer::preprocessEventListener(LocalFrame*, const String& sou rce, const String& url, const String& functionName)
623 { 624 {
624 return source; 625 return source;
625 } 626 }
626 627
627 } // namespace WebCore 628 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698