Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine.h

Issue 306813002: [SyncFS] Make routines using metadata database async (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_engine.h
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine.h b/chrome/browser/sync_file_system/drive_backend/sync_engine.h
index 45bf4b344f379ca6fd622d7161cf8c0958ba235b..85494f854d7f455d5855d714f60a0a6e53628ebf 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_engine.h
+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine.h
@@ -121,8 +121,6 @@ class SyncEngine : public RemoteFileSyncService,
drive::DriveServiceInterface* GetDriveService();
drive::DriveUploaderInterface* GetDriveUploader();
- MetadataDatabase* GetMetadataDatabase();
- SyncTaskManager* GetSyncTaskManagerForTesting();
void OnPendingFileListUpdated(int item_count);
void OnFileStatusChanged(const fileapi::FileSystemURL& url,
@@ -145,7 +143,10 @@ class SyncEngine : public RemoteFileSyncService,
ExtensionServiceInterface* extension_service,
SigninManagerBase* signin_manager);
- void UpdateRegisteredApps();
+ // TODO(peria): Migrate this method into test code.
+ // This method is not thread safe, because it requires to access metadata
+ // database which may live in another thread.
+ void UpdateRegisteredAppsForTesting();
scoped_ptr<drive::DriveServiceInterface> drive_service_;
scoped_ptr<DriveServiceWrapper> drive_service_wrapper_;

Powered by Google App Engine
This is Rietveld 408576698