chrome/browser/sync_file_system/drive_backend/sync_engine.h - Issue 306813002: [SyncFS] Make routines using metadata database async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine.h

Issue 306813002: [SyncFS] Make routines using metadata database async (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add a note comment Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync_file_system/drive_backend/sync_engine.h

diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine.h b/chrome/browser/sync_file_system/drive_backend/sync_engine.h

index 45bf4b344f379ca6fd622d7161cf8c0958ba235b..ed31daaf18a707967ac967c49a748929b45c453f 100644

--- a/chrome/browser/sync_file_system/drive_backend/sync_engine.h

+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine.h

@@ -121,8 +121,6 @@ class SyncEngine : public RemoteFileSyncService,

drive::DriveServiceInterface* GetDriveService();

drive::DriveUploaderInterface* GetDriveUploader();

- MetadataDatabase* GetMetadataDatabase();

- SyncTaskManager* GetSyncTaskManagerForTesting();

void OnPendingFileListUpdated(int item_count);

void OnFileStatusChanged(const fileapi::FileSystemURL& url,

@@ -145,7 +143,7 @@ class SyncEngine : public RemoteFileSyncService,

ExtensionServiceInterface* extension_service,

SigninManagerBase* signin_manager);

- void UpdateRegisteredApps();

+ void UpdateRegisteredAppsForTesting();

nhiroki 2014/06/02 05:43:56 How about having a comment like "This is not threa

peria 2014/06/02 05:57:30 Done.

scoped_ptr<drive::DriveServiceInterface> drive_service_;

scoped_ptr<DriveServiceWrapper> drive_service_wrapper_;