Issue 306803003: Correctly show self time in trace event details pie chart

Issue 306803003: Correctly show self time in trace event details pie chart (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Correctly show self time in trace event details pie chart BUG=361045 R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175110

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -13 lines)			Patch
	M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View	1	3 chunks	+19 lines, -13 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

alph

lgtm https://codereview.chromium.org/306803003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js File Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/306803003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode742 Source/devtools/front_end/timeline/TimelineUIUtils.js:742: fragment.appendChild(WebInspector.TimelineUIUtils.generatePieChart(stats.aggregatedStats, WebInspector.TimelineUIUtils.styleForTimelineEvent(event.name).category, event.selfTime)); I'd move the fragment.appendChild out ...

6 years, 6 months ago (2014-05-29 10:11:15 UTC) #2

yurys

https://codereview.chromium.org/306803003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js File Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/306803003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode742 Source/devtools/front_end/timeline/TimelineUIUtils.js:742: fragment.appendChild(WebInspector.TimelineUIUtils.generatePieChart(stats.aggregatedStats, WebInspector.TimelineUIUtils.styleForTimelineEvent(event.name).category, event.selfTime)); On 2014/05/29 10:11:16, alph wrote: > ...

6 years, 6 months ago (2014-05-29 12:40:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/306803003/20001

6 years, 6 months ago (2014-05-29 12:42:54 UTC) #5

alph

https://codereview.chromium.org/306803003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js File Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/306803003/diff/1/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode908 Source/devtools/front_end/timeline/TimelineUIUtils.js:908: var index = events.binaryIndexOf(event.startTime, eventComparator); nit: you can move ...

6 years, 6 months ago (2014-05-29 12:59:27 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...

6 years, 6 months ago (2014-05-29 20:22:40 UTC) #7

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 6 months ago (2014-05-29 21:37:13 UTC) #8

commit-bot: I haz the power

Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9734)

6 years, 6 months ago (2014-05-29 21:37:14 UTC) #9

yurys

6 years, 6 months ago (2014-05-30 08:15:55 UTC) #10

Message was sent while issue was closed.

Committed patchset #2 manually as r175110 (presubmit successful).

Expand Messages | Collapse Messages