Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issue 306803002: Revert of Chromium plumbing to use the selection root bounds. (Closed)

Created:
6 years, 6 months ago by jdduke (slow)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org, timvolodine, nasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Chromium plumbing to use the selection root bounds. (https://codereview.chromium.org/186753002/) Reason for revert: The Android plumbing to use the root selection bounds has been removed, and the visibility calculation will soon be performed by the compositor (see crbug.com/135959). Original issue's description: > Chromium plumbing to use the selection root bounds. > > This is asking the selection root bounds to Blink and send it back to > the RenderWidgetHostView implementation in the browser process. > > BUG=236033 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=257199 TBR=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273628

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -94 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 1 chunk +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 chunks +0 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_base.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl_android.cc View 1 2 chunks +0 lines, -19 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M content/renderer/render_widget.cc View 1 3 chunks +0 lines, -9 lines 0 comments Download
M content/test/test_render_view_host.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
jdduke (slow)
Created Revert of Chromium plumbing to use the selection root bounds.
6 years, 6 months ago (2014-05-29 00:52:40 UTC) #1
mlamouri (slow - plz ping)
On 2014/05/29 00:52:40, jdduke wrote: > Created Revert of Chromium plumbing to use the selection ...
6 years, 6 months ago (2014-05-29 08:59:06 UTC) #2
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 6 months ago (2014-05-29 14:51:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/306803002/1
6 years, 6 months ago (2014-05-29 14:52:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 15:25:05 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 15:28:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/32177) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/36174)
6 years, 6 months ago (2014-05-29 15:28:06 UTC) #7
jdduke (slow)
The CQ bit was unchecked by jdduke@chromium.org
6 years, 6 months ago (2014-05-29 15:53:05 UTC) #8
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 6 months ago (2014-05-29 15:58:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/306803002/140001
6 years, 6 months ago (2014-05-29 16:00:47 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 19:09:02 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 19:14:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/11905)
6 years, 6 months ago (2014-05-29 19:14:49 UTC) #13
jdduke (slow)
The CQ bit was checked by jdduke@chromium.org
6 years, 6 months ago (2014-05-29 21:00:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/306803002/140001
6 years, 6 months ago (2014-05-29 21:05:33 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 22:34:14 UTC) #16
Message was sent while issue was closed.
Change committed as 273628

Powered by Google App Engine
This is Rietveld 408576698