Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 306783003: PerformanceTests/Bindings/scroll-top.html should use another DOM attribute (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
Reviewers:
eae, adamk
CC:
blink-reviews
Visibility:
Public.

Description

PerformanceTests/Bindings/scroll-top.html should use another DOM attribute scroll-top.html is intended to test performance of DOM attributes that return small integers. Due to a recent change to Element.scrollTop, Element.scrollTop no longer returns small integers (it returns a double value). So this CL updates the performance test so that it uses Node.nodeType. BUG=371429 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
A + PerformanceTests/Bindings/node-type.html View 1 chunk +2 lines, -2 lines 0 comments Download
D PerformanceTests/Bindings/scroll-top.html View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
PTAL
6 years, 6 months ago (2014-05-29 00:52:11 UTC) #1
eae
Great, thank you. LGTM
6 years, 6 months ago (2014-05-29 00:59:09 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-05-29 01:00:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/306783003/1
6 years, 6 months ago (2014-05-29 01:01:15 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 02:18:39 UTC) #5
Message was sent while issue was closed.
Change committed as 175021

Powered by Google App Engine
This is Rietveld 408576698