Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: media/cast/test/end2end_unittest.cc

Issue 306783002: [Cast] Clean-up: Merge AudioReceiverConfig+VideoReceiverConfig-->FrameReceiverConfig. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Removed kFakeSoftwareAudio in AudioCodec enum, per hclam@. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/rtp_receiver/rtp_receiver.cc ('k') | media/cast/test/receiver.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/test/end2end_unittest.cc
diff --git a/media/cast/test/end2end_unittest.cc b/media/cast/test/end2end_unittest.cc
index ae55fae76c5ac647b05e4c435cceece35006b3a0..119067c7b29fe5cf0c12116f8c6f8a5365179ad5 100644
--- a/media/cast/test/end2end_unittest.cc
+++ b/media/cast/test/end2end_unittest.cc
@@ -461,7 +461,6 @@ class End2EndTest : public ::testing::Test {
void Configure(transport::VideoCodec video_codec,
transport::AudioCodec audio_codec,
int audio_sampling_frequency,
- bool external_audio_decoder,
int max_number_of_video_buffers_used) {
audio_sender_config_.rtp_config.ssrc = 1;
audio_sender_config_.rtp_config.max_delay_ms = kTargetPlayoutDelayMs;
@@ -479,10 +478,10 @@ class End2EndTest : public ::testing::Test {
audio_receiver_config_.rtp_max_delay_ms = kTargetPlayoutDelayMs;
audio_receiver_config_.rtp_payload_type =
audio_sender_config_.rtp_config.payload_type;
- audio_receiver_config_.use_external_decoder = external_audio_decoder;
audio_receiver_config_.frequency = audio_sender_config_.frequency;
audio_receiver_config_.channels = kAudioChannels;
- audio_receiver_config_.codec = audio_sender_config_.codec;
+ audio_receiver_config_.max_frame_rate = 100;
+ audio_receiver_config_.codec.audio = audio_sender_config_.codec;
test_receiver_audio_callback_->SetExpectedSamplingFrequency(
audio_receiver_config_.frequency);
@@ -510,8 +509,10 @@ class End2EndTest : public ::testing::Test {
video_receiver_config_.rtp_max_delay_ms = kTargetPlayoutDelayMs;
video_receiver_config_.rtp_payload_type =
video_sender_config_.rtp_config.payload_type;
- video_receiver_config_.use_external_decoder = false;
- video_receiver_config_.codec = video_sender_config_.codec;
+ video_receiver_config_.frequency = kVideoFrequency;
+ video_receiver_config_.channels = 1;
+ video_receiver_config_.max_frame_rate = video_sender_config_.max_frame_rate;
+ video_receiver_config_.codec.video = video_sender_config_.codec;
}
void SetReceiverSkew(double skew, base::TimeDelta offset) {
@@ -731,8 +732,8 @@ class End2EndTest : public ::testing::Test {
}
}
- AudioReceiverConfig audio_receiver_config_;
- VideoReceiverConfig video_receiver_config_;
+ FrameReceiverConfig audio_receiver_config_;
+ FrameReceiverConfig video_receiver_config_;
AudioSenderConfig audio_sender_config_;
VideoSenderConfig video_sender_config_;
@@ -784,7 +785,7 @@ class End2EndTest : public ::testing::Test {
};
TEST_F(End2EndTest, LoopNoLossPcm16) {
- Configure(transport::kVp8, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kVp8, transport::kPcm16, 32000, 1);
// Reduce video resolution to allow processing multiple frames within a
// reasonable time frame.
video_sender_config_.width = kVideoQcifWidth;
@@ -838,7 +839,7 @@ TEST_F(End2EndTest, LoopNoLossPcm16) {
// This tests our external decoder interface for Audio.
// Audio test without packet loss using raw PCM 16 audio "codec";
TEST_F(End2EndTest, LoopNoLossPcm16ExternalDecoder) {
- Configure(transport::kVp8, transport::kPcm16, 32000, true, 1);
+ Configure(transport::kVp8, transport::kPcm16, 32000, 1);
Create();
const int kNumIterations = 10;
@@ -856,8 +857,7 @@ TEST_F(End2EndTest, LoopNoLossPcm16ExternalDecoder) {
// This tests our Opus audio codec without video.
TEST_F(End2EndTest, LoopNoLossOpus) {
- Configure(transport::kVp8, transport::kOpus, kDefaultAudioSamplingRate,
- false, 1);
+ Configure(transport::kVp8, transport::kOpus, kDefaultAudioSamplingRate, 1);
Create();
const int kNumIterations = 300;
@@ -883,8 +883,7 @@ TEST_F(End2EndTest, LoopNoLossOpus) {
// in audio_receiver.cc for likely cause(s) of this bug.
// http://crbug.com/356942
TEST_F(End2EndTest, DISABLED_StartSenderBeforeReceiver) {
- Configure(transport::kVp8, transport::kPcm16, kDefaultAudioSamplingRate,
- false, 1);
+ Configure(transport::kVp8, transport::kPcm16, kDefaultAudioSamplingRate, 1);
Create();
int video_start = kVideoStart;
@@ -972,8 +971,7 @@ TEST_F(End2EndTest, DISABLED_StartSenderBeforeReceiver) {
// This tests a network glitch lasting for 10 video frames.
// Flaky. See crbug.com/351596.
TEST_F(End2EndTest, DISABLED_GlitchWith3Buffers) {
- Configure(transport::kVp8, transport::kOpus, kDefaultAudioSamplingRate,
- false, 3);
+ Configure(transport::kVp8, transport::kOpus, kDefaultAudioSamplingRate, 3);
video_sender_config_.rtp_config.max_delay_ms = 67;
video_receiver_config_.rtp_max_delay_ms = 67;
Create();
@@ -1036,8 +1034,7 @@ TEST_F(End2EndTest, DISABLED_GlitchWith3Buffers) {
// Disabled due to flakiness and crashiness. http://crbug.com/360951
TEST_F(End2EndTest, DISABLED_DropEveryOtherFrame3Buffers) {
- Configure(transport::kVp8, transport::kOpus, kDefaultAudioSamplingRate, false,
- 3);
+ Configure(transport::kVp8, transport::kOpus, kDefaultAudioSamplingRate, 3);
video_sender_config_.rtp_config.max_delay_ms = 67;
video_receiver_config_.rtp_max_delay_ms = 67;
Create();
@@ -1075,7 +1072,7 @@ TEST_F(End2EndTest, DISABLED_DropEveryOtherFrame3Buffers) {
}
TEST_F(End2EndTest, CryptoVideo) {
- Configure(transport::kVp8, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kVp8, transport::kPcm16, 32000, 1);
video_sender_config_.rtp_config.aes_iv_mask =
ConvertFromBase16String("1234567890abcdeffedcba0987654321");
@@ -1113,7 +1110,7 @@ TEST_F(End2EndTest, CryptoVideo) {
}
TEST_F(End2EndTest, CryptoAudio) {
- Configure(transport::kVp8, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kVp8, transport::kPcm16, 32000, 1);
audio_sender_config_.rtp_config.aes_iv_mask =
ConvertFromBase16String("abcdeffedcba12345678900987654321");
@@ -1142,7 +1139,7 @@ TEST_F(End2EndTest, CryptoAudio) {
// Video test without packet loss - tests the logging aspects of the end2end,
// but is basically equivalent to LoopNoLossPcm16.
TEST_F(End2EndTest, VideoLogging) {
- Configure(transport::kVp8, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kVp8, transport::kPcm16, 32000, 1);
Create();
int video_start = kVideoStart;
@@ -1266,7 +1263,7 @@ TEST_F(End2EndTest, VideoLogging) {
// Audio test without packet loss - tests the logging aspects of the end2end,
// but is basically equivalent to LoopNoLossPcm16.
TEST_F(End2EndTest, AudioLogging) {
- Configure(transport::kVp8, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kVp8, transport::kPcm16, 32000, 1);
Create();
int audio_diff = kFrameTimerMs;
@@ -1344,7 +1341,7 @@ TEST_F(End2EndTest, AudioLogging) {
}
TEST_F(End2EndTest, BasicFakeSoftwareVideo) {
- Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, 1);
Create();
StartBasicPlayer();
SetReceiverSkew(1.0, base::TimeDelta::FromMilliseconds(1));
@@ -1365,7 +1362,7 @@ TEST_F(End2EndTest, BasicFakeSoftwareVideo) {
}
TEST_F(End2EndTest, ReceiverClockFast) {
- Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, 1);
Create();
StartBasicPlayer();
SetReceiverSkew(2.0, base::TimeDelta::FromMicroseconds(1234567));
@@ -1380,7 +1377,7 @@ TEST_F(End2EndTest, ReceiverClockFast) {
}
TEST_F(End2EndTest, ReceiverClockSlow) {
- Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, 1);
Create();
StartBasicPlayer();
SetReceiverSkew(0.5, base::TimeDelta::FromMicroseconds(-765432));
@@ -1395,7 +1392,7 @@ TEST_F(End2EndTest, ReceiverClockSlow) {
}
TEST_F(End2EndTest, SmoothPlayoutWithFivePercentClockRateSkew) {
- Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, 1);
Create();
StartBasicPlayer();
SetReceiverSkew(1.05, base::TimeDelta::FromMilliseconds(-42));
@@ -1416,7 +1413,7 @@ TEST_F(End2EndTest, SmoothPlayoutWithFivePercentClockRateSkew) {
}
TEST_F(End2EndTest, EvilNetwork) {
- Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, false, 1);
+ Configure(transport::kFakeSoftwareVideo, transport::kPcm16, 32000, 1);
receiver_to_sender_.SetPacketPipe(test::EvilNetwork().Pass());
sender_to_receiver_.SetPacketPipe(test::EvilNetwork().Pass());
Create();
« no previous file with comments | « media/cast/rtp_receiver/rtp_receiver.cc ('k') | media/cast/test/receiver.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698