pkg/barback/lib/src/utils/cancelable_future.dart - Issue 306773002: Fix a bug where barback transformers would produce stale output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/barback/lib/src/utils/cancelable_future.dart

Issue 306773002: Fix a bug where barback transformers would produce stale output. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/barback/lib/src/transformer/aggregate_transform.dart ('k') | pkg/barback/test/package_graph/transform/concurrency_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/barback/lib/src/utils/cancelable_future.dart

diff --git a/pkg/barback/lib/src/utils/cancelable_future.dart b/pkg/barback/lib/src/utils/cancelable_future.dart

index ff723b287f8f86ee90dd2ea69f937108e6cf80fa..64d2b5fa203e4eb9c98a7039a504325adfb7ccbc 100644

--- a/pkg/barback/lib/src/utils/cancelable_future.dart

+++ b/pkg/barback/lib/src/utils/cancelable_future.dart

@@ -14,7 +14,7 @@ import 'dart:async';

/// running.

class CancelableFuture<T> implements Future<T> {

bool _canceled = false;

- final _completer = new Completer<T>();

+ final _completer = new Completer<T>.sync();

CancelableFuture(Future<T> inner) {

inner.then((result) {