Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: content/browser/frame_host/debug_urls.cc

Issue 306753003: Add some function and URLs to induce ASan crashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use the new Asan debug functions in the crash urls. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/debug_urls.cc
diff --git a/content/browser/frame_host/debug_urls.cc b/content/browser/frame_host/debug_urls.cc
index 0542f9e77570aea15d3cc1faa29a6846c0d2340b..1c9e4de7a0522397b97a41eb0fa058d27b4823b3 100644
--- a/content/browser/frame_host/debug_urls.cc
+++ b/content/browser/frame_host/debug_urls.cc
@@ -6,6 +6,8 @@
#include <vector>
+#include "base/debug/asan_invalid_access.h"
+#include "base/debug/profiler.h"
#include "base/strings/utf_string_conversions.h"
#include "content/browser/gpu/gpu_process_host_ui_shim.h"
#include "content/browser/ppapi_plugin_process_host.h"
@@ -19,6 +21,16 @@ namespace content {
namespace {
+// Define the Asan debug URLs.
+static const char kAsanCrashDomain[] = "crash";
+static const char kAsanHeapOverflow[] = "/browser-heap-overflow";
+static const char kAsanHeapUnderflow[] = "/browser-heap-underflow";
+static const char kAsanUseAfterFree[] = "/browser-use-after-free";
+#if defined(SYZYASAN)
+static const char kAsanCorruptHeapBlock[] = "/browser-corrupt-heap-block";
+static const char kAsanCorruptHeap[] = "/browser-corrupt-heap";
+#endif
+
void HandlePpapiFlashDebugURL(const GURL& url) {
#if defined(ENABLE_PLUGINS)
bool crash = url == GURL(kChromeUIPpapiFlashCrashURL);
@@ -36,6 +48,51 @@ void HandlePpapiFlashDebugURL(const GURL& url) {
#endif
}
+bool IsAsanDebugURL(const GURL& url) {
+#if defined(SYZYASAN)
+ if (!base::debug::IsBinaryInstrumented())
+ return false;
+#endif
+ return url.is_valid() &&
+ url.DomainIs(kAsanCrashDomain, sizeof(kAsanCrashDomain) - 1) &&
+ url.has_path() && (url.path() == kAsanHeapOverflow ||
+ url.path() == kAsanHeapUnderflow ||
+ url.path() == kAsanUseAfterFree ||
+#if defined(SYZYASAN) && defined(COMPILER_MSVC)
+ url.path() == kAsanCorruptHeapBlock ||
+ url.path() == kAsanCorruptHeap
+#endif
+ );
+}
+
+bool HandleAsanDebugURL(const GURL& url) {
+#if defined(SYZYASAN)
+ if (!base::debug::IsBinaryInstrumented())
+ return false;
+
+ if (url.path() == kAsanCorruptHeapBlock) {
+ base::AsanCorruptHeapBlock();
+ return true;
+ } else if (url.path() == kAsanCorruptHeap) {
+ base::AsanCorruptHeap();
+ return true;
+ }
+#endif
+
+ if (url.path() == kAsanHeapOverflow) {
+ base::AsanHeapOverflow();
+ } else if (url.path() == kAsanHeapUnderflow) {
+ base::AsanHeapUnderflow();
+ } else if (url.path() == kAsanUseAfterFree) {
+ base::AsanHeapUseAfterFree();
+ } else {
+ return false;
+ }
+
+ return true;
+}
+
+
} // namespace
bool HandleDebugURL(const GURL& url, PageTransition transition) {
@@ -46,6 +103,9 @@ bool HandleDebugURL(const GURL& url, PageTransition transition) {
// NOTE: when you add handling of any URLs to this function, also
// update IsDebugURL, below.
+ if (IsAsanDebugURL(url))
+ return HandleAsanDebugURL(url);
+
if (url.host() == kChromeUIBrowserCrashHost) {
// Induce an intentional crash in the browser process.
CHECK(false);
@@ -86,7 +146,7 @@ bool HandleDebugURL(const GURL& url, PageTransition transition) {
bool IsDebugURL(const GURL& url) {
// NOTE: when you add any URLs to this list, also update
// HandleDebugURL, above.
- return IsRendererDebugURL(url) ||
+ return IsRendererDebugURL(url) || IsAsanDebugURL(url) ||
(url.is_valid() &&
(url.host() == kChromeUIBrowserCrashHost ||
url == GURL(kChromeUIGpuCleanURL) ||

Powered by Google App Engine
This is Rietveld 408576698