Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: Source/bindings/v8/V8Utilities.cpp

Issue 30673002: More informative error messages for non-Transferables. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: More informative error messages for non-Transferables. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8Utilities.h ('k') | Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Utilities.cpp
diff --git a/Source/bindings/v8/V8Utilities.cpp b/Source/bindings/v8/V8Utilities.cpp
index 7d4e64becdf738f6e2ed32f9598ea4f023cbc46a..24e27b15fb80d7814933de36e88ddf4e57b543bc 100644
--- a/Source/bindings/v8/V8Utilities.cpp
+++ b/Source/bindings/v8/V8Utilities.cpp
@@ -63,7 +63,7 @@ void createHiddenDependency(v8::Handle<v8::Object> object, v8::Local<v8::Value>
cacheArray->Set(v8::Integer::New(cacheArray->Length(), isolate), value);
}
-bool extractTransferables(v8::Local<v8::Value> value, MessagePortArray& ports, ArrayBufferArray& arrayBuffers, v8::Isolate* isolate)
+bool extractTransferables(v8::Local<v8::Value> value, MessagePortArray& ports, ArrayBufferArray& arrayBuffers, bool& notASequence, v8::Isolate* isolate)
{
if (isUndefinedOrNull(value)) {
ports.resize(0);
@@ -76,7 +76,7 @@ bool extractTransferables(v8::Local<v8::Value> value, MessagePortArray& ports, A
v8::Local<v8::Array> array = v8::Local<v8::Array>::Cast(value);
length = array->Length();
} else {
- if (toV8Sequence(value, length, isolate).IsEmpty())
+ if (toV8Sequence(value, length, &notASequence, isolate).IsEmpty())
return false;
}
« no previous file with comments | « Source/bindings/v8/V8Utilities.h ('k') | Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698