Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(734)

Side by Side Diff: Source/bindings/v8/V8Utilities.h

Issue 30673002: More informative error messages for non-Transferables. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: More informative error messages for non-Transferables. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/V8Utilities.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // Combo create/remove, for generated event-handler-setter bindings: 51 // Combo create/remove, for generated event-handler-setter bindings:
52 void transferHiddenDependency(v8::Handle<v8::Object>, EventListener* oldValu e, v8::Local<v8::Value> newValue, int cacheIndex, v8::Isolate*); 52 void transferHiddenDependency(v8::Handle<v8::Object>, EventListener* oldValu e, v8::Local<v8::Value> newValue, int cacheIndex, v8::Isolate*);
53 53
54 ExecutionContext* getExecutionContext(); 54 ExecutionContext* getExecutionContext();
55 55
56 typedef WTF::Vector<RefPtr<MessagePort>, 1> MessagePortArray; 56 typedef WTF::Vector<RefPtr<MessagePort>, 1> MessagePortArray;
57 typedef WTF::Vector<RefPtr<ArrayBuffer>, 1> ArrayBufferArray; 57 typedef WTF::Vector<RefPtr<ArrayBuffer>, 1> ArrayBufferArray;
58 58
59 // Helper function which pulls the values out of a JS sequence and into a Me ssagePortArray. 59 // Helper function which pulls the values out of a JS sequence and into a Me ssagePortArray.
60 // Also validates the elements per sections 4.1.13 and 4.1.15 of the WebIDL spec and section 8.3.3 60 // Also validates the elements per sections 4.1.13 and 4.1.15 of the WebIDL spec and section 8.3.3
61 // of the HTML5 spec and generates exceptions as appropriate. 61 // of the HTML5 spec and generates exceptions as appropriate. If the supplie d argument's type isn't
62 // a JS sequence, a type error is signalled by setting 'notASequence' to tru e -- the caller
63 // then being responsible for generating a TypeError having a message that f its the context.
62 // Returns true if the array was filled, or false if the passed value was no t of an appropriate type. 64 // Returns true if the array was filled, or false if the passed value was no t of an appropriate type.
63 bool extractTransferables(v8::Local<v8::Value>, MessagePortArray&, ArrayBuff erArray&, v8::Isolate*); 65 bool extractTransferables(v8::Local<v8::Value>, MessagePortArray&, ArrayBuff erArray&, bool& notASequence, v8::Isolate*);
64 bool getMessagePortArray(v8::Local<v8::Value>, MessagePortArray&, v8::Isolat e*); 66 bool getMessagePortArray(v8::Local<v8::Value>, MessagePortArray&, v8::Isolat e*);
65 67
66 } // namespace WebCore 68 } // namespace WebCore
67 69
68 #endif // V8Utilities_h 70 #endif // V8Utilities_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/V8Utilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698