More informative error messages for non-Transferables.

Source/bindings/v8/custom/V8DedicatedWorkerGlobalScopeCustom.cpp

 /*
  * Copyright (C) 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 13 matching lines @@
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #include "config.h"
 #include "V8DedicatedWorkerGlobalScope.h"
 
+#include "bindings/v8/ExceptionMessages.h"
 #include "bindings/v8/ExceptionState.h"
 #include "bindings/v8/V8Binding.h"
 #include "bindings/v8/V8Utilities.h"
 #include "bindings/v8/V8WorkerGlobalScopeEventListener.h"
 #include "core/workers/DedicatedWorkerGlobalScope.h"
 #include "wtf/ArrayBuffer.h"
 
 namespace WebCore {
 
 void V8DedicatedWorkerGlobalScope::postMessageMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& args)
 {
     DedicatedWorkerGlobalScope* workerGlobalScope = V8DedicatedWorkerGlobalScope::toNative(args.Holder());
     MessagePortArray ports;
     ArrayBufferArray arrayBuffers;
     if (args.Length() > 1) {
-        if (!extractTransferables(args[1], ports, arrayBuffers, args.GetIsolate()))
+        bool notASequence = false;
+        if (!extractTransferables(
+            args[1], ports, arrayBuffers, notASequence, args.GetIsolate())) {

[Mike West, 2013/10/22 06:50:40]

Nit: The line breaks here are strange. Generally speaking, Blink does not have a
line-length limit, so you can just leave this on one line.

[sof, 2013/10/22 16:06:56]

Sorry, presubmit checks leading me to assume wrongly about reqd formatting. Top
tip :)

+            if (notASequence) {
+                throwTypeError(ExceptionMessages::failedToExecute(
+                    "postMessage", "WorkerGlobalScope", ExceptionMessages::notASequenceType("Second")), args.GetIsolate());

[Mike West, 2013/10/22 06:50:40]

Nit: line breaks.

+            }
             return;
+        }
     }
     bool didThrow = false;
     RefPtr<SerializedScriptValue> message =
         SerializedScriptValue::create(args[0],
                                       &ports,
                                       &arrayBuffers,
                                       didThrow,
                                       args.GetIsolate());
     if (didThrow)
         return;
     ExceptionState es(args.GetIsolate());
     workerGlobalScope->postMessage(message.release(), &ports, es);
     es.throwIfNeeded();
 }
 
 } // namespace WebCore