base/file_util_posix.cc - Issue 3067013: posix: print error message when mkdtemp fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/file_util_posix.cc

Issue 3067013: posix: print error message when mkdtemp fails. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/file_util_posix.cc

diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc

index 434c859f945769c75b9c73bafca836ae3131b1de..4d9cf42080edd90ddc793b43fa1f924f0674f994 100644

--- a/base/file_util_posix.cc

+++ b/base/file_util_posix.cc

@@ -420,8 +420,10 @@ static bool CreateTemporaryDirInDirImpl(const FilePath& base_dir,

// this should be OK since mkdtemp just replaces characters in place

char* buffer = const_cast<char*>(sub_dir_string.c_str());

char* dtemp = mkdtemp(buffer);

- if (!dtemp)

+ if (!dtemp) {

+ DPLOG(ERROR) << "mkdtemp";

Nico 2010/07/28 20:57:52 << errno? or does DPLOG do that already?

return false;

+ }

*new_dir = FilePath(dtemp);

return true;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »