Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 306693003: DevTools: Unflake inspector/profiler/cpu-profiler-profile-removal.html (Closed)

Created:
6 years, 6 months ago by alph
Modified:
6 years, 6 months ago
Reviewers:
yurys, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Unflake inspector/profiler/cpu-profiler-profile-removal.html The test callback was called from within the ProfilesPanel.showProfile() and put the panel in a non-expected state. BUG=378389 R=yurys@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175054

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M LayoutTests/inspector/profiler/cpu-profiler-profile-removal.html View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
alph
6 years, 6 months ago (2014-05-28 18:30:58 UTC) #1
yurys
lgtm
6 years, 6 months ago (2014-05-29 09:29:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/306693003/1
6 years, 6 months ago (2014-05-29 09:29:55 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 10:43:13 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 11:26:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9633)
6 years, 6 months ago (2014-05-29 11:26:35 UTC) #6
alph
The CQ bit was checked by alph@chromium.org
6 years, 6 months ago (2014-05-29 12:32:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/306693003/1
6 years, 6 months ago (2014-05-29 12:34:41 UTC) #8
alph
6 years, 6 months ago (2014-05-29 12:37:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r175054 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698