Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 306673002: Qualify include paths in bindings/v8 (Closed)

Created:
6 years, 6 months ago by Nils Barth (inactive)
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, dglazkov+blink, dominicc+watchlist_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Qualify include paths in bindings/v8 This finishes qualifying include paths in bindings! There are some remaining unqualified paths into bindings from core generated files, so we can't yet remove the include directories from core.gyp, but bindings is sorted! TBR=haraken BUG=358074 BUG=377364 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175247

Patch Set 1 #

Patch Set 2 : Fix GC path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -95 lines) Patch
M Source/bindings/v8/CustomElementConstructorBuilder.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/CustomElementWrapper.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/DOMWrapperWorld.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/Dictionary.cpp View 1 chunk +18 lines, -20 lines 0 comments Download
M Source/bindings/v8/IDBBindingUtilities.cpp View 1 chunk +9 lines, -9 lines 0 comments Download
M Source/bindings/v8/PageScriptDebugServer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptController.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptProfiler.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8DOMWrapper.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8ErrorHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8EventListenerList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8GCController.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/V8LazyEventListener.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8MutationCallback.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8NPObject.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/v8/V8NodeFilterCondition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8ThrowException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/WorkerScriptController.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/core.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Nils Barth (inactive)
Last one for bindings!
6 years, 6 months ago (2014-05-28 13:06:28 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-05-28 13:06:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/306673002/1
6 years, 6 months ago (2014-05-28 13:07:19 UTC) #3
haraken
LGTM
6 years, 6 months ago (2014-05-28 13:20:34 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-28 14:59:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-28 15:22:24 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/20946)
6 years, 6 months ago (2014-05-28 15:22:24 UTC) #7
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-02 01:24:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/306673002/20001
6 years, 6 months ago (2014-06-02 01:25:07 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-02 02:39:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 02:39:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12744)
6 years, 6 months ago (2014-06-02 02:39:43 UTC) #12
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 6 months ago (2014-06-02 02:51:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/306673002/20001
6 years, 6 months ago (2014-06-02 02:52:02 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 03:21:40 UTC) #15
Message was sent while issue was closed.
Change committed as 175247

Powered by Google App Engine
This is Rietveld 408576698