Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 306633002: Split bindings output between core and modules! (Closed)

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Split bindings output between core and modules! Finally, splitting bindings output! Mostly straightforward, with 2 twists: * need a separate cache directory for the scripts, not just the output directory (to avoid needing to precache twice) * aggregate bindings files need to know the component Followup is: * Generate qualified paths in includes * remove bindings subdirs from core includes! R=haraken BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174949

Patch Set 1 #

Patch Set 2 : Fix aggregate paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -115 lines) Patch
M Source/bindings/core/core.gypi View 1 chunk +9 lines, -4 lines 0 comments Download
M Source/bindings/core/generated.gyp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/generated.gyp View 1 5 chunks +14 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/generated.gypi View 1 chunk +22 lines, -20 lines 0 comments Download
M Source/bindings/modules/generated.gyp View 5 chunks +10 lines, -8 lines 0 comments Download
M Source/bindings/modules/modules.gypi View 1 chunk +8 lines, -4 lines 0 comments Download
M Source/bindings/modules/v8/generated.gyp View 1 5 chunks +12 lines, -8 lines 0 comments Download
M Source/bindings/modules/v8/generated.gypi View 1 chunk +22 lines, -20 lines 0 comments Download
M Source/bindings/scripts/aggregate_generated_bindings.py View 1 5 chunks +11 lines, -7 lines 0 comments Download
M Source/bindings/scripts/code_generator_v8.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/idl_compiler.py View 6 chunks +10 lines, -5 lines 0 comments Download
M Source/bindings/scripts/scripts.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/scripts/scripts.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gyp View 2 chunks +23 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
Finally splitting output!
6 years, 7 months ago (2014-05-28 07:11:46 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-28 07:16:14 UTC) #2
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-28 08:10:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/306633002/20001
6 years, 7 months ago (2014-05-28 08:11:07 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 09:25:16 UTC) #5
Message was sent while issue was closed.
Change committed as 174949

Powered by Google App Engine
This is Rietveld 408576698