Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 30663003: Merge 159007 "Notify nodes removal to Range/Selection after disp..." (Closed)

Created:
7 years, 2 months ago by yosin_UTC9
Modified:
7 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

Merge 159007 "Notify nodes removal to Range/Selection after disp..." > Notify nodes removal to Range/Selection after dispatching blur and mutation event > > This patch changes notifying nodes removal to Range/Selection after dispatching blur and mutation event. In willRemoveChildren(), like willRemoveChild(); r115686 did same change, although it didn't change willRemoveChildren(). > > The issue 295010, use-after-free, is caused by setting removed node to Selection in mutation event handler. > > BUG=295010 > TEST=LayoutTests/fast/dom/Range/range-created-during-remove-children.html, LayoutTests/editing/selection/selection-change-in-mutation-event-by-remove-children.html, LayoutTests/editing/selection/selection-change-in-blur-event-by-remove-children.html > R=tkent@chromium.org > > Review URL: https://codereview.chromium.org/25389004 TBR=yosin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160037

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
yosin_UTC9
7 years, 2 months ago (2013-10-21 01:33:33 UTC) #1
yosin_UTC9
7 years, 2 months ago (2013-10-21 01:34:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r160037.

Powered by Google App Engine
This is Rietveld 408576698