Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3931)

Unified Diff: build/vs_toolchain.py

Issue 306613002: Add support for VS express to the GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/win/visual_studio_version.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/vs_toolchain.py
diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py
index 4b925f0799f2ade1abbb97834b44ebdddc591a85..287aed6f2ff6445aa6e6698a7eeb8d6ac1080bb6 100644
--- a/build/vs_toolchain.py
+++ b/build/vs_toolchain.py
@@ -143,8 +143,15 @@ def GetToolchainDir():
"""Gets location information about the current toolchain (must have been
previously updated by 'update')."""
scottmg 2014/05/28 17:42:21 Add a comment that this is used for GN here (I cou
SetEnvironmentAndGetRuntimeDllDirs()
- print '["%s", "%s"]' % (
- os.environ['GYP_MSVS_OVERRIDE_PATH'], os.environ['WINDOWSSDKDIR'])
+ print """vs_path = "%s"
brettw 2014/05/28 05:29:55 I wasn't sure how to wrap this.
scottmg 2014/05/28 17:42:21 """ -> '''
+sdk_path = "%s"
+vs_version = "%s"
+wdk_dir = "%s"
+""" % (
+ os.environ['GYP_MSVS_OVERRIDE_PATH'],
+ os.environ['WINDOWSSDKDIR'],
+ os.environ['GYP_MSVS_VERSION'],
+ os.environ['WDK_DIR'])
def main():
« no previous file with comments | « build/config/win/visual_studio_version.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698