Issue 306613002: Add support for VS express to the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306613002: Add support for VS express to the GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for VS express to the GN build. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273345

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -8 lines)			Patch
M	build/config/win/BUILD.gn	View		4 chunks	+34 lines, -1 line	0 comments	Download
M	build/config/win/visual_studio_version.gni	View		2 chunks	+23 lines, -4 lines	0 comments	Download
M	build/vs_toolchain.py	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

Please check carefully, we don't have a lot of use of ATL in the Win ...

6 years, 6 months ago (2014-05-28 05:29:54 UTC) #1

scottmg

lgtm https://codereview.chromium.org/306613002/diff/1/build/vs_toolchain.py File build/vs_toolchain.py (right): https://codereview.chromium.org/306613002/diff/1/build/vs_toolchain.py#newcode144 build/vs_toolchain.py:144: previously updated by 'update').""" Add a comment that ...

6 years, 6 months ago (2014-05-28 17:42:21 UTC) #2

brettw

6 years, 6 months ago (2014-05-28 20:32:05 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r273345 (presubmit successful).

Expand Messages | Collapse Messages

Issue 306613002: Add support for VS express to the GN build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages