Don't run tests against pinned barback versions in third_party.

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index b87d7ea7da33f104b6fdc0c9d554be9066ca4d0c..0c72a1b89de7511c1f8f1448a827608769e5bf6a 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -415,6 +415,11 @@ abstract class TestSuite {
       for (var result in results) {
         for (var packageTuple in result) {
           String packageName = packageTuple[0];
+
+          // Some packages are pinned to specific versions. We can ignore those
+          // for the purposes of testing.
+          if (packageName.contains('-')) continue;

[kustermann, 2014/05/27 23:28:17]

I'd prefer if you move this logic into the "isValid(packageName)" function above
and constrain it more, something like:

isValid(packageName) {
  return !['third_party', 'barback-0.13.0'].contains(packageName);
}

You're more familiar with the package name constraints: Is "-" disallowed in the
directory names for pub packages? If so, I'm also fine with "-", but I'd still
move it up to "isValid(...)" and extend the comment saying that directories
containing "-" are not valid pub packages.

[nweiz, 2014/05/27 23:56:22]

Done.
Package names can't contain "-"; they have to be valid Dart identifiers. I think
it's better to check for "-" because we're likely to add more pinned versions of
barback in the future.

+
           String fullPath = packageTuple[1];
           String yamlFile =
               new Path(fullPath).append('pubspec.yaml').toNativePath();