Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 306583007: make new blurrect GM and replace the dozens of existing ones (Closed)

Created:
6 years, 6 months ago by humper
Modified:
6 years, 6 months ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

make new blurrect GM and replace the dozens of existing ones BUG= NOTRY=True Committed: http://code.google.com/p/skia/source/detail?r=14940

Patch Set 1 #

Patch Set 2 : don't disable ALL the GMs, silly #

Patch Set 3 : fix signed unsigned #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -74 lines) Patch
M gm/blurrect.cpp View 1 2 2 chunks +84 lines, -74 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
humper
ptal -- one blurrect to rule them all
6 years, 6 months ago (2014-05-28 21:01:08 UTC) #1
reed1
lgtm
6 years, 6 months ago (2014-05-28 21:07:45 UTC) #2
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-28 21:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/306583007/20001
6 years, 6 months ago (2014-05-28 21:08:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium ...
6 years, 6 months ago (2014-05-28 21:15:10 UTC) #5
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-28 21:16:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/306583007/40001
6 years, 6 months ago (2014-05-28 21:16:53 UTC) #7
epoger
The CQ bit was unchecked by epoger@google.com
6 years, 6 months ago (2014-05-28 21:25:48 UTC) #8
epoger
I unchecked the commit box, because I'm worried about how hard it is going to ...
6 years, 6 months ago (2014-05-28 21:28:39 UTC) #9
humper
On 2014/05/28 21:28:39, epoger wrote: > I unchecked the commit box, because I'm worried about ...
6 years, 6 months ago (2014-05-28 21:34:20 UTC) #10
humper
The CQ bit was checked by humper@google.com
6 years, 6 months ago (2014-05-28 21:51:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/humper@google.com/306583007/40001
6 years, 6 months ago (2014-05-28 21:52:07 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 21:52:14 UTC) #13
Message was sent while issue was closed.
Change committed as 14940

Powered by Google App Engine
This is Rietveld 408576698