Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 306583006: Free memory in the mock array buffer allocator. (Closed)

Created:
6 years, 6 months ago by Yang
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Free memory in the mock array buffer allocator. Turns out ASAN and valgrind notice if you leak 0 allocated bytes. R=jkummerow@chromium.org, jochen@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/d8.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 6 months ago (2014-05-28 10:56:46 UTC) #1
Jakob Kummerow
lgtm
6 years, 6 months ago (2014-05-28 10:58:55 UTC) #2
Yang
6 years, 6 months ago (2014-05-28 11:00:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698