Issue 306583005: Avoid to insert TAB before HTML element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306583005: Avoid to insert TAB before HTML element (Closed)

Created:
6 years, 6 months ago by yosin_UTC9

Modified:
6 years, 6 months ago

Reviewers:
yoichio, Yuta Kitamura

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Avoid to insert TAB before HTML element This patch changes InsertTextCommand::insertTab before HTML element because we can't set Text node as document element. BUG=348209 TEST=LayoutTests/editing/execCommand/insert-tab-to-html-element-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175047

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, --1 lines)			Patch
A	LayoutTests/editing/execCommand/insert-tab-to-html-element-crash.html	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A +	LayoutTests/editing/execCommand/insert-tab-to-html-element-crash-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/editing/InsertTextCommand.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/306583005/1

6 years, 6 months ago (2014-05-29 07:44:58 UTC) #5

Message was sent while issue was closed.

Change committed as 175047

Expand Messages | Collapse Messages