Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 306583005: Avoid to insert TAB before HTML element (Closed)

Created:
6 years, 6 months ago by yosin_UTC9
Modified:
6 years, 6 months ago
Reviewers:
yoichio, Yuta Kitamura
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Avoid to insert TAB before HTML element This patch changes InsertTextCommand::insertTab before HTML element because we can't set Text node as document element. BUG=348209 TEST=LayoutTests/editing/execCommand/insert-tab-to-html-element-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175047

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, --1 lines) Patch
A LayoutTests/editing/execCommand/insert-tab-to-html-element-crash.html View 1 chunk +18 lines, -0 lines 0 comments Download
A + LayoutTests/editing/execCommand/insert-tab-to-html-element-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/editing/InsertTextCommand.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yosin_UTC9
Could you review this patch? Thanks in advance.
6 years, 6 months ago (2014-05-29 01:40:56 UTC) #1
yoichio
lgtm
6 years, 6 months ago (2014-05-29 02:19:02 UTC) #2
Yuta Kitamura
lgtm
6 years, 6 months ago (2014-05-29 06:49:40 UTC) #3
yosin_UTC9
The CQ bit was checked by yosin@chromium.org
6 years, 6 months ago (2014-05-29 07:44:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/306583005/1
6 years, 6 months ago (2014-05-29 07:44:58 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 10:32:07 UTC) #6
Message was sent while issue was closed.
Change committed as 175047

Powered by Google App Engine
This is Rietveld 408576698