net/quic/quic_connection_test.cc - Issue 306573002: Add an IncreaseLargestObserved to QuicUnackedPacketMap to remove the rtt

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_connection_test.cc

Issue 306573002: Add an IncreaseLargestObserved to QuicUnackedPacketMap to remove the rtt (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_connection_test.cc

diff --git a/net/quic/quic_connection_test.cc b/net/quic/quic_connection_test.cc

index 2c0fecc0225e11d57081787d19740f826133929e..f5dda3ce99f83477a68df10a309ce1f937367667 100644

--- a/net/quic/quic_connection_test.cc

+++ b/net/quic/quic_connection_test.cc

@@ -1958,9 +1958,9 @@ TEST_P(QuicConnectionTest, RetransmitWriteBlockedAckedOriginalThenSent) {

ProcessAckPacket(&ack);

connection_.OnPacketSent(WriteResult(WRITE_STATUS_OK, 0));

- // The retransmission alarm should not be set because there are

- // no unacked packets.

- EXPECT_FALSE(connection_.GetRetransmissionAlarm()->IsSet());

+ // There is now a pending packet, but with no retransmittable frames.

+ EXPECT_TRUE(connection_.GetRetransmissionAlarm()->IsSet());

+ EXPECT_FALSE(connection_.sent_packet_manager().HasRetransmittableFrames(2));

}

TEST_P(QuicConnectionTest, AlarmsWhenWriteBlocked) {

« no previous file with comments | « net/quic/quic_connection.cc ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »