Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 306563002: Entering debugger scope should not make debugger active. (Closed)

Created:
6 years, 6 months ago by Yang
Modified:
6 years, 6 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Entering debugger scope should not make debugger active. The motivation is that by only entering the debugger scope to call into the debug context should not cause code to be compiled for debugging. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M src/debug.cc View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
This depends on https://codereview.chromium.org/297303006/
6 years, 6 months ago (2014-05-27 15:31:29 UTC) #1
Yang
On 2014/05/27 15:31:29, Yang wrote: > This depends on https://codereview.chromium.org/297303006/ I had the comment on ...
6 years, 6 months ago (2014-06-02 12:54:58 UTC) #2
ulan
lgtm
6 years, 6 months ago (2014-06-02 14:00:53 UTC) #3
Yang
6 years, 6 months ago (2014-06-03 14:33:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21645.

Powered by Google App Engine
This is Rietveld 408576698