src/ia32/code-stubs-ia32.cc - Issue 306513002: Convert ElementsKind into a BitField

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/code-stubs-ia32.cc

Issue 306513002: Convert ElementsKind into a BitField (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/code-stubs-ia32.cc

diff --git a/src/ia32/code-stubs-ia32.cc b/src/ia32/code-stubs-ia32.cc

index 5547ba25e86294c7838a7885f0374535f4afb76c..5695719b583d91ada5d5377c65f874b0e821c4e6 100644

--- a/src/ia32/code-stubs-ia32.cc

+++ b/src/ia32/code-stubs-ia32.cc

@@ -4952,8 +4952,7 @@ void InternalArrayConstructorStub::Generate(MacroAssembler* masm) {

// but the following masking takes care of that anyway.

__ mov(ecx, FieldOperand(ecx, Map::kBitField2Offset));

// Retrieve elements_kind from bit field 2.

- __ and_(ecx, Map::kElementsKindMask);

- __ shr(ecx, Map::kElementsKindShift);

+ __ DecodeField<Map::ElementsKindBits>(ecx);

if (FLAG_debug_code) {

Label done;

« no previous file with comments | « src/arm64/macro-assembler-arm64.cc ('k') | src/ia32/macro-assembler-ia32.cc » ('j') | no next file with comments »