Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 306513002: Convert ElementsKind into a BitField (Closed)

Created:
6 years, 7 months ago by danno
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Convert ElementsKind into a BitField R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21515

Patch Set 1 #

Patch Set 2 : DBC feedback from Toon #

Patch Set 3 : Missed one #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -34 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 2 chunks +8 lines, -15 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
6 years, 7 months ago (2014-05-27 09:02:03 UTC) #1
Yang
On 2014/05/27 09:02:03, danno wrote: lgtm.
6 years, 7 months ago (2014-05-27 09:04:08 UTC) #2
danno
6 years, 7 months ago (2014-05-27 09:38:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r21515 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698