Try to roll angle again.

Try to roll angle again.

BUG=skia:2272
NOTRY=True
NOTREECHECKS=True
R=reed@google.com

Committed: https://skia.googlesource.com/skia/+/08fe013

[bsalomon, 2014-05-28 19:28:19]

Hey Geoff, I tried to reland the ANGLE roll, but now I'm getting a lot of unused
warnings (as errors) about unused vars in the release build:


[64/712] CXX
obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft
Visual Studio 12.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC
@obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj.rsp
/c ..\..\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\Image9.cpp
/Foobj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
/FdlibGLESv2.pdb
d:\src\skia\third_party\externals\angle2\src\libglesv2\renderer\d3d9\image9.cpp(242)
: error C4189: 'result' : local variable is initialized but not referenced

I'm sure how to turn this warning off just for angle without turning it off for
the rest of the skia build as well.

[Geoff Lang, 2014-05-28 20:12:00]

On 2014/05/28 19:28:19, bsalomon wrote:
> Hey Geoff, I tried to reland the ANGLE roll, but now I'm getting a lot of
unused
> warnings (as errors) about unused vars in the release build:
> 
> 
> [64/712] CXX
>
obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
> FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files (x86)\Microsoft
> Visual Studio 12.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC
>
@obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj.rsp
> /c ..\..\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\Image9.cpp
>
/Foobj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
> /FdlibGLESv2.pdb
>
d:\src\skia\third_party\externals\angle2\src\libglesv2\renderer\d3d9\image9.cpp(242)
> : error C4189: 'result' : local variable is initialized but not referenced
> 
> I'm sure how to turn this warning off just for angle without turning it off
for
> the rest of the skia build as well.

Hey, thanks for getting this going again, I haven't had time in a while.

I was seeing this issue a bit myself while testing, some of our gyp warning
disables are ignored... I'm fixing the warnings ANGLE side now and I'll roll
angle to that revision.

[bsalomon, 2014-05-29 01:10:23]

On 2014/05/28 20:12:00, Geoff Lang wrote:
> On 2014/05/28 19:28:19, bsalomon wrote:
> > Hey Geoff, I tried to reland the ANGLE roll, but now I'm getting a lot of
> unused
> > warnings (as errors) about unused vars in the release build:
> > 
> > 
> > [64/712] CXX
> >
>
obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
> > FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files
(x86)\Microsoft
> > Visual Studio 12.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC
> >
>
@obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj.rsp
> > /c ..\..\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\Image9.cpp
> >
>
/Foobj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
> > /FdlibGLESv2.pdb
> >
>
d:\src\skia\third_party\externals\angle2\src\libglesv2\renderer\d3d9\image9.cpp(242)
> > : error C4189: 'result' : local variable is initialized but not referenced
> > 
> > I'm sure how to turn this warning off just for angle without turning it off
> for
> > the rest of the skia build as well.
> 
> Hey, thanks for getting this going again, I haven't had time in a while.
> 
> I was seeing this issue a bit myself while testing, some of our gyp warning
> disables are ignored... I'm fixing the warnings ANGLE side now and I'll roll
> angle to that revision.

It also looks like ANGLE isn't building with 2010 anymore. If that's not
supported then we should switch our ANGLE bots to use 2012 or 2013.

[Geoff Lang, 2014-05-29 14:21:33]

On 2014/05/29 01:10:23, bsalomon wrote:
> On 2014/05/28 20:12:00, Geoff Lang wrote:
> > On 2014/05/28 19:28:19, bsalomon wrote:
> > > Hey Geoff, I tried to reland the ANGLE roll, but now I'm getting a lot of
> > unused
> > > warnings (as errors) about unused vars in the release build:
> > > 
> > > 
> > > [64/712] CXX
> > >
> >
>
obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
> > > FAILED: ninja -t msvc -e environment.x86 -- "C:\Program Files
> (x86)\Microsoft
> > > Visual Studio 12.0\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC
> > >
> >
>
@obj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj.rsp
> > > /c
..\..\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\Image9.cpp
> > >
> >
>
/Foobj\third_party\externals\angle2\src\libGLESv2\renderer\d3d9\libGLESv2.Image9.obj
> > > /FdlibGLESv2.pdb
> > >
> >
>
d:\src\skia\third_party\externals\angle2\src\libglesv2\renderer\d3d9\image9.cpp(242)
> > > : error C4189: 'result' : local variable is initialized but not referenced
> > > 
> > > I'm sure how to turn this warning off just for angle without turning it
off
> > for
> > > the rest of the skia build as well.
> > 
> > Hey, thanks for getting this going again, I haven't had time in a while.
> > 
> > I was seeing this issue a bit myself while testing, some of our gyp warning
> > disables are ignored... I'm fixing the warnings ANGLE side now and I'll roll
> > angle to that revision.
> 
> It also looks like ANGLE isn't building with 2010 anymore. If that's not
> supported then we should switch our ANGLE bots to use 2012 or 2013.

Ah, yes.  We followed chromium and dropped support for VS2010 recently.

[bsalomon, 2014-05-29 14:32:10]

I filed http://skbug.com/2622 to update the version of VS used for our ANGLE
bots.

[bsalomon, 2014-06-17 21:13:45]

Looks like the trys pass except GM. I propose landing and rebaselining in the
morning.

[reed1, 2014-06-17 21:14:37]

lgtm

[bsalomon, 2014-06-17 21:14:43]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2014-06-17 21:17:21]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2014-06-17 21:17:30]

The CQ bit was checked by bsalomon@google.com

[reed1, 2014-06-17 21:22:21]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-06-17 21:22:23]

The CQ bit was unchecked by reed@google.com

[reed1, 2014-06-17 21:22:29]

The CQ bit was checked by reed@google.com

[reed1, 2014-06-17 21:24:04]

The CQ bit was unchecked by reed@google.com

[bsalomon, 2014-06-17 21:28:41]

Committed patchset #3 manually as r08fe013.