Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 306483013: X87: Avoid HeapObject check in HStoreNamedField. (Closed)

Created:
6 years, 6 months ago by Weiliang
Modified:
6 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

X87: Avoid HeapObject check in HStoreNamedField. port r21509 (78a54b0) Original commit message: This way an HStoreNamedField instruction can never deoptimize itself, which is another important step towards a working store elimination. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21547

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -35 lines) Patch
M src/x87/lithium-codegen-x87.cc View 2 chunks +6 lines, -25 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +1 line, -10 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Weiliang
6 years, 6 months ago (2014-05-28 06:10:41 UTC) #1
danno
lgtm
6 years, 6 months ago (2014-05-28 07:57:59 UTC) #2
Weiliang
6 years, 6 months ago (2014-05-28 08:16:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21547.

Powered by Google App Engine
This is Rietveld 408576698