Combine background repaint conditions in RenderStyle and RenderObject

Combine background repaint conditions in RenderStyle and RenderObject

Combined RenderStyle::needsFullRepaintOnContainer(Width|Height)Change
and local function mustRepaintFillLayers() in RenderObject.cpp into
RenderObject::mustRepaintFillLayersOn(Width|Height)Change.

Added missing logics of the original mustRepaintFillLayers():
- repaint if background-repeat is not repeat and no-repeat;
- repaint if background-position is not left or top origin;
- don't repaint if background-position is of fixed length;

TEST=fast/repaint/background-resize-width.html
TEST=fast/repaint/background-resize-height.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175172

[Xianzhu, 2014-05-29 16:34:16]

ping...

[esprehn, 2014-05-29 22:20:11]

lgtm, this looks fine. Seems like mostly just code moving?

Please fix the nits before landing.

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.cpp:841: bool
RenderObject::borderImageIsLoadedAndCanBeRendered() const
canRenderBorderImage()

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.h (right):

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.h:531: bool
mustRepaintFillLayersOnWidthChange(const FillLayer*) const;
References

[Xianzhu, 2014-05-30 00:47:55]

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.cpp (right):

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.cpp:841: bool
RenderObject::borderImageIsLoadedAndCanBeRendered() const
On 2014/05/29 22:20:12, esprehn wrote:
> canRenderBorderImage()

Done.

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
File Source/core/rendering/RenderObject.h (right):

https://codereview.chromium.org/306483011/diff/20001/Source/core/rendering/Re...
Source/core/rendering/RenderObject.h:531: bool
mustRepaintFillLayersOnWidthChange(const FillLayer*) const;
On 2014/05/29 22:20:12, esprehn wrote:
> References

Done.

[Xianzhu, 2014-05-30 00:48:01]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-30 00:50:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/306483011/30001

[commit-bot: I haz the power, 2014-05-30 16:00:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9633)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9945)

[commit-bot: I haz the power, 2014-05-30 16:44:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 16:44:56]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9648)

[Xianzhu, 2014-05-30 17:24:07]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-30 17:25:38]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/306483011/50001

[commit-bot: I haz the power, 2014-05-30 18:41:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6537)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[commit-bot: I haz the power, 2014-05-30 19:20:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 19:20:16]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6547)

[Xianzhu, 2014-05-30 19:20:49]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-05-30 19:21:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/306483011/50001

[commit-bot: I haz the power, 2014-05-30 23:28:25]

Change committed as 175172