Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 306483010: Revert of PictureBenchmark JSON logging (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of PictureBenchmark JSON logging (https://codereview.chromium.org/286903025/) Reason for revert: Broke some Windows builds; see http://skbug.com/2609 ('certain Windows Build-* bots failing since r14905'). Before re-landing with a fix, please send to some of the trybots that failed the first time. Original issue's description: > Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h > > JSON format described in code, above PictureJSONResultsWriter class > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14906 TBR=bensong@google.com,jcgregorio@google.com,kelvinly@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2609 Committed: http://code.google.com/p/skia/source/detail?r=14910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -410 lines) Patch
M bench/ResultsWriter.h View 3 chunks +21 lines, -5 lines 0 comments Download
D bench/ResultsWriter.cpp View 1 chunk +0 lines, -33 lines 0 comments Download
M bench/TimerData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M bench/TimerData.cpp View 1 chunk +0 lines, -83 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/tools.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/PictureBenchmark.h View 4 chunks +4 lines, -4 lines 0 comments Download
M tools/PictureBenchmark.cpp View 7 chunks +40 lines, -27 lines 0 comments Download
D tools/PictureResultsWriter.h View 1 chunk +0 lines, -232 lines 0 comments Download
M tools/bench_pictures_main.cpp View 7 chunks +5 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
epoger
Created Revert of PictureBenchmark JSON logging
6 years, 7 months ago (2014-05-27 21:50:56 UTC) #1
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-05-27 21:51:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/306483010/1
6 years, 7 months ago (2014-05-27 21:51:29 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 21:51:45 UTC) #4
Message was sent while issue was closed.
Change committed as 14910

Powered by Google App Engine
This is Rietveld 408576698