Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 306483006: Add a flag to d8 to invoke weak callbacks (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Add a flag to d8 to invoke weak callbacks This will send an idle notification and a low memory notification after each test. For some reason it's not enough to send a low memory notification alone. BUG=none R=yangguo@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21529

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -11 lines) Patch
M src/d8.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/d8.cc View 1 4 chunks +23 lines, -10 lines 0 comments Download
M tools/run-tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 13:39:46 UTC) #1
Yang
LGTM with comment. https://codereview.chromium.org/306483006/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/306483006/diff/1/src/d8.cc#newcode1387 src/d8.cc:1387: } This duplicate code could be ...
6 years, 7 months ago (2014-05-27 13:42:04 UTC) #2
jochen (gone - plz use gerrit)
6 years, 7 months ago (2014-05-27 13:57:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698