Plumb file system permission into WebviewGuest.

chrome/browser/renderer_host/chrome_render_message_filter.cc

Index: chrome/browser/renderer_host/chrome_render_message_filter.cc
diff --git a/chrome/browser/renderer_host/chrome_render_message_filter.cc b/chrome/browser/renderer_host/chrome_render_message_filter.cc
index f50fb11bdd247aeb51c0a6fae8fe715db38a2f3b..f07d38f83c242ee83142562fbbd786a7e94c0935 100644
--- a/chrome/browser/renderer_host/chrome_render_message_filter.cc
+++ b/chrome/browser/renderer_host/chrome_render_message_filter.cc
@@ -19,6 +19,7 @@
 #include "chrome/browser/extensions/activity_log/activity_log.h"
 #include "chrome/browser/extensions/api/activity_log_private/activity_log_private_api.h"
 #include "chrome/browser/extensions/api/messaging/message_service.h"
+#include "chrome/browser/extensions/extension_renderer_state.h"
 #include "chrome/browser/metrics/chrome_metrics_service_accessor.h"
 #include "chrome/browser/net/chrome_url_request_context.h"
 #include "chrome/browser/net/predictor.h"
@@ -123,8 +124,9 @@ bool ChromeRenderMessageFilter::OnMessageReceived(const IPC::Message& message) {
                         OnAddEventToExtensionActivityLog);
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AllowDatabase, OnAllowDatabase)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AllowDOMStorage, OnAllowDOMStorage)
-    IPC_MESSAGE_HANDLER(ChromeViewHostMsg_RequestFileSystemAccessSync,
-                        OnRequestFileSystemAccessSync)
+    IPC_MESSAGE_HANDLER_DELAY_REPLY(
+        ChromeViewHostMsg_RequestFileSystemAccessSync,
+        OnRequestFileSystemAccessSync)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_RequestFileSystemAccessAsync,
                         OnRequestFileSystemAccessAsync)
     IPC_MESSAGE_HANDLER(ChromeViewHostMsg_AllowIndexedDB, OnAllowIndexedDB)
@@ -439,14 +441,38 @@ void ChromeRenderMessageFilter::OnRequestFileSystemAccessSync(
     int render_frame_id,
     const GURL& origin_url,
     const GURL& top_origin_url,
-    bool* allowed) {
-  *allowed =
+    IPC::Message* reply_msg) {
+  bool allowed =
       cookie_settings_->IsSettingCookieAllowed(origin_url, top_origin_url);
   // Record access to file system for potential display in UI.
+  ExtensionRendererState::WebViewInfo webview_info;
+  // Never hide requests from guest processes.
+  bool is_web_view_guest =
+      ExtensionRendererState::GetInstance()->IsWebViewRenderer(
+          render_process_id_);
+  if (!is_web_view_guest) {
+    ChromeViewHostMsg_RequestFileSystemAccessSync::WriteReplyParams(reply_msg,
+                                                                    allowed);
+    Send(reply_msg);
+    BrowserThread::PostTask(
+        BrowserThread::UI,
+        FROM_HERE,
+        base::Bind(&TabSpecificContentSettings::FileSystemAccessedSync,

[Fady Samuel, 2014/05/29 21:36:25]

TabSpecificContentSettings::FileSystemAccessed

[Xi Han, 2014/05/30 14:38:35]

Done.

+                   render_process_id_,
+                   render_frame_id,
+                   origin_url,
+                   !allowed));
+    return;
+  }
   BrowserThread::PostTask(
-      BrowserThread::UI, FROM_HERE,
-      base::Bind(&TabSpecificContentSettings::FileSystemAccessed,
-                 render_process_id_, render_frame_id, origin_url, !*allowed));
+      BrowserThread::UI,
+      FROM_HERE,
+      base::Bind(&TabSpecificContentSettings::FileSystemAccessedSyncDelayReply,

[Fady Samuel, 2014/05/29 21:36:25]

Why not go directly to WebViewGuest?

Implement this in WebViewGuest::FileSystemAccessSync

[Xi Han, 2014/05/30 14:38:35]

Done.

+                 render_process_id_,
+                 render_frame_id,
+                 origin_url,
+                 reply_msg,
+                 !allowed));
 }
 
 void ChromeRenderMessageFilter::OnRequestFileSystemAccessAsync(
@@ -458,20 +484,16 @@ void ChromeRenderMessageFilter::OnRequestFileSystemAccessAsync(
 
   bool allowed =
       cookie_settings_->IsSettingCookieAllowed(origin_url, top_origin_url);
-  // Record access to file system for potential display in UI.

[Fady Samuel, 2014/05/29 21:36:25]

Detect WebView up here, and call WebViewGuest::FileSystemAccessedAsync.

[Xi Han, 2014/05/30 14:38:35]

Done.

+
   BrowserThread::PostTask(
-      BrowserThread::UI, FROM_HERE,
-      base::Bind(
-          &TabSpecificContentSettings::FileSystemAccessed,
-          render_process_id_,
-          render_frame_id,
-          origin_url,
-          !allowed));
-
-  Send(new ChromeViewMsg_RequestFileSystemAccessAsyncResponse(
-      render_frame_id,
-      request_id,
-      allowed));
+      BrowserThread::UI,
+      FROM_HERE,
+      base::Bind(&TabSpecificContentSettings::FileSystemAccessedAsync,

[Fady Samuel, 2014/05/29 21:36:25]

TabSpecificContetSettings::FileSystemAccessed

[Xi Han, 2014/05/30 14:38:35]

Done.

+                 render_process_id_,
+                 render_frame_id,
+                 request_id,
+                 origin_url,
+                 !allowed));
 }
 
 void ChromeRenderMessageFilter::OnAllowIndexedDB(int render_frame_id,