Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2704)

Unified Diff: chrome/renderer/resources/extensions/web_view.js

Issue 306473012: Plumb file system permission into WebviewGuest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small changes are made. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/web_view.js
diff --git a/chrome/renderer/resources/extensions/web_view.js b/chrome/renderer/resources/extensions/web_view.js
index f0578f7ae76c0d5be08fe63fa17a66c46c24723f..079ff10613b007b2dd431818c490fcd0260b05d8 100644
--- a/chrome/renderer/resources/extensions/web_view.js
+++ b/chrome/renderer/resources/extensions/web_view.js
@@ -687,7 +687,12 @@ WebViewInternal.prototype.setupEventProperty = function(eventName) {
*/
WebViewInternal.prototype.getPermissionTypes = function() {
var permissions =
- ['media', 'geolocation', 'pointerLock', 'download', 'loadplugin'];
+ ['media',
+ 'geolocation',
+ 'pointerLock',
+ 'download',
+ 'loadplugin',
+ 'filesystem'];
not at google - send to devlin 2014/06/05 16:57:04 what does it mean for a webview to have the 'files
Xi Han 2014/06/05 16:59:59 From my understanding, it means the embedder can c
not at google - send to devlin 2014/06/05 17:03:17 what kind of file system access? like access outsi
Xi Han 2014/06/05 17:09:37 It is html file system access, starting from windo
not at google - send to devlin 2014/06/05 17:12:50 Ok cool. I'm all for explicitly enabling features
Xi Han 2014/06/05 17:24:00 Honestly, I don't know exactly why, but maybe beca
not at google - send to devlin 2014/06/05 17:30:39 That would make sense, but I thought requestFileSy
Xi Han 2014/06/05 17:45:07 The guest can request both "Temporary" or "Persist
return permissions.concat(this.maybeGetExperimentalPermissions());
};

Powered by Google App Engine
This is Rietveld 408576698