Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/renderer/resources/extensions/web_view.js

Issue 306473012: Plumb file system permission into WebviewGuest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Small changes are made. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This module implements Webview (<webview>) as a custom element that wraps a 5 // This module implements Webview (<webview>) as a custom element that wraps a
6 // BrowserPlugin object element. The object element is hidden within 6 // BrowserPlugin object element. The object element is hidden within
7 // the shadow DOM of the Webview element. 7 // the shadow DOM of the Webview element.
8 8
9 var DocumentNatives = requireNative('document_natives'); 9 var DocumentNatives = requireNative('document_natives');
10 var EventBindings = require('event_bindings'); 10 var EventBindings = require('event_bindings');
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 }, 680 },
681 enumerable: true 681 enumerable: true
682 }); 682 });
683 }; 683 };
684 684
685 /** 685 /**
686 * @private 686 * @private
687 */ 687 */
688 WebViewInternal.prototype.getPermissionTypes = function() { 688 WebViewInternal.prototype.getPermissionTypes = function() {
689 var permissions = 689 var permissions =
690 ['media', 'geolocation', 'pointerLock', 'download', 'loadplugin']; 690 ['media',
691 'geolocation',
692 'pointerLock',
693 'download',
694 'loadplugin',
695 'filesystem'];
not at google - send to devlin 2014/06/05 16:57:04 what does it mean for a webview to have the 'files
Xi Han 2014/06/05 16:59:59 From my understanding, it means the embedder can c
not at google - send to devlin 2014/06/05 17:03:17 what kind of file system access? like access outsi
Xi Han 2014/06/05 17:09:37 It is html file system access, starting from windo
not at google - send to devlin 2014/06/05 17:12:50 Ok cool. I'm all for explicitly enabling features
Xi Han 2014/06/05 17:24:00 Honestly, I don't know exactly why, but maybe beca
not at google - send to devlin 2014/06/05 17:30:39 That would make sense, but I thought requestFileSy
Xi Han 2014/06/05 17:45:07 The guest can request both "Temporary" or "Persist
691 return permissions.concat(this.maybeGetExperimentalPermissions()); 696 return permissions.concat(this.maybeGetExperimentalPermissions());
692 }; 697 };
693 698
694 /** 699 /**
695 * @private 700 * @private
696 */ 701 */
697 WebViewInternal.prototype.handleDialogEvent = 702 WebViewInternal.prototype.handleDialogEvent =
698 function(event, webViewEvent) { 703 function(event, webViewEvent) {
699 var showWarningMessage = function(dialogType) { 704 var showWarningMessage = function(dialogType) {
700 var VOWELS = ['a', 'e', 'i', 'o', 'u']; 705 var VOWELS = ['a', 'e', 'i', 'o', 'u'];
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
1285 1290
1286 /** 1291 /**
1287 * Implemented when the experimental API is available. 1292 * Implemented when the experimental API is available.
1288 * @private 1293 * @private
1289 */ 1294 */
1290 WebViewInternal.prototype.setupExperimentalContextMenus_ = function() {}; 1295 WebViewInternal.prototype.setupExperimentalContextMenus_ = function() {};
1291 1296
1292 exports.WebView = WebView; 1297 exports.WebView = WebView;
1293 exports.WebViewInternal = WebViewInternal; 1298 exports.WebViewInternal = WebViewInternal;
1294 exports.CreateEvent = CreateEvent; 1299 exports.CreateEvent = CreateEvent;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698