Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 306473008: Fix for NeedsManualRebaseline lines in TestExpectations (Closed)

Created:
6 years, 7 months ago by harpreet.sk
Modified:
6 years, 6 months ago
Reviewers:
ojan
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix for NeedsManualRebaseline lines in TestExpectations This patch provides the fix for NeedsManualRebaseline lines in TestExpectations added in following revision https://src.chromium.org/viewvc/blink?revision=174761&view=revision Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175270

Patch Set 1 #

Patch Set 2 : Doing Rebaseline Manuallly #

Patch Set 3 : Fixing expected result for win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/fast/repaint/button-spurious-layout-hint-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
A + LayoutTests/platform/linux/fast/repaint/button-spurious-layout-hint-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/platform/mac/fast/repaint/button-spurious-layout-hint-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/platform/win-xp/fast/repaint/button-spurious-layout-hint-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/platform/win/fast/repaint/button-spurious-layout-hint-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
harpreet.sk
ptal
6 years, 7 months ago (2014-05-28 09:15:30 UTC) #1
ojan
For changes that have already cycled through the bots, you can do the rebaseline manually ...
6 years, 6 months ago (2014-05-28 17:55:34 UTC) #2
harpreet.sk
On 2014/05/28 17:55:34, ojan wrote: > For changes that have already cycled through the bots, ...
6 years, 6 months ago (2014-05-29 07:37:16 UTC) #3
ojan
lgtm
6 years, 6 months ago (2014-05-30 00:40:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/306473008/20001
6 years, 6 months ago (2014-05-30 00:42:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 15:51:58 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 16:53:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9953)
6 years, 6 months ago (2014-05-30 16:53:25 UTC) #8
harpreet.sk
The CQ bit was checked by harpreet.sk@samsung.com
6 years, 6 months ago (2014-06-02 09:20:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/306473008/40001
6 years, 6 months ago (2014-06-02 09:20:30 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 10:31:10 UTC) #11
Message was sent while issue was closed.
Change committed as 175270

Powered by Google App Engine
This is Rietveld 408576698