Issue 306473003: Don't over split DOM tree in CompositeEditCommand::splitTreeToNode

Issue 306473003: Don't over split DOM tree in CompositeEditCommand::splitTreeToNode (Closed)

Created:
6 years, 7 months ago by yosin_UTC9

Modified:
6 years, 6 months ago

Reviewers:
yoichio, Yuta Kitamura

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Don't over split DOM tree in CompositeEditCommand::splitTreeToNode This patch changes CompositeEditCommand::splitTreeToNode not to split when tree parent parameter |start| isn't descendant of |end| node parameter. The root cause of issue 350843 is we call |positionInParentAfterNode()| with dangling BLOCKQUOTE element which is tried to insert HTML element as result of |splitTreeNode()|, which is called BODY element, and HR element; HR element is child of BODY element. BUG=350843 TEST=LayoutTests/editing/execCommand/indent-table-cell-crash.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174951

Patch Set 1 : 2014-05-27T01:56:21 #

Total comments: 5

Patch Set 2 : 2014-05-27T06:26:59 #

Patch Set 3 : 2014-05-28T05:18:57 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -11 lines)			Patch
A +	LayoutTests/editing/execCommand/indent-table-cell-crash.html	View	1	2 chunks	+3 lines, -10 lines	0 comments	Download
A +	LayoutTests/editing/execCommand/indent-table-cell-crash-expected.txt	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/editing/CompositeEditCommand.cpp	View	1 2	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

Yuta Kitamura

https://codereview.chromium.org/306473003/diff/20001/LayoutTests/editing/execCommand/indent-table-cell-crash.html File LayoutTests/editing/execCommand/indent-table-cell-crash.html (right): https://codereview.chromium.org/306473003/diff/20001/LayoutTests/editing/execCommand/indent-table-cell-crash.html#newcode11 LayoutTests/editing/execCommand/indent-table-cell-crash.html:11: document.designMode = 'on'; nit: Please use 4-space indent. https://codereview.chromium.org/306473003/diff/20001/Source/core/editing/CompositeEditCommand.cpp ...

6 years, 7 months ago (2014-05-27 07:41:26 UTC) #2

yosin_UTC9

PTAL https://codereview.chromium.org/306473003/diff/20001/LayoutTests/editing/execCommand/indent-table-cell-crash.html File LayoutTests/editing/execCommand/indent-table-cell-crash.html (right): https://codereview.chromium.org/306473003/diff/20001/LayoutTests/editing/execCommand/indent-table-cell-crash.html#newcode11 LayoutTests/editing/execCommand/indent-table-cell-crash.html:11: document.designMode = 'on'; On 2014/05/27 07:41:27, Yuta Kitamura ...

6 years, 7 months ago (2014-05-27 09:30:06 UTC) #3

Yuta Kitamura

https://codereview.chromium.org/306473003/diff/20001/Source/core/editing/CompositeEditCommand.cpp File Source/core/editing/CompositeEditCommand.cpp (left): https://codereview.chromium.org/306473003/diff/20001/Source/core/editing/CompositeEditCommand.cpp#oldcode1463 Source/core/editing/CompositeEditCommand.cpp:1463: break; On 2014/05/27 09:30:06, yosi wrote: > On 2014/05/27 ...

6 years, 6 months ago (2014-05-28 07:44:17 UTC) #4

yosin_UTC9

PTAL Restore "if (!parentNode()->isEleemntNode()) break" On 2014/05/28 07:44:17, Yuta Kitamura wrote: > https://codereview.chromium.org/306473003/diff/20001/Source/core/editing/CompositeEditCommand.cpp > File ...

6 years, 6 months ago (2014-05-28 08:22:10 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yosin@chromium.org/306473003/60001

6 years, 6 months ago (2014-05-28 09:30:57 UTC) #8

Message was sent while issue was closed.

Change committed as 174951

Expand Messages | Collapse Messages