Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 306453006: Don't disable forceCompositingMode in PinchViewportTest.TestWebViewResizedBeforeAttachment. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
bokan, enne (OOO)
CC:
blink-reviews, danakj
Visibility:
Public.

Description

Don't disable forceCompositingMode in PinchViewportTest.TestWebViewResizedBeforeAttachment. We're getting rid of the forceCompositingMode setting. This is one of two remaining callers that sets it to false. For now, disable accelerated compositing entirely. Verified that the test still fails when r173949 is reverted. BUG=377851, 363772 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M Source/web/tests/PinchViewportTest.cpp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
ojan
6 years, 6 months ago (2014-05-27 17:35:48 UTC) #1
bokan
lgtm
6 years, 6 months ago (2014-05-27 18:15:09 UTC) #2
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-05-27 18:58:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/306453006/1
6 years, 6 months ago (2014-05-27 18:58:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-27 22:27:12 UTC) #5
ojan
The CQ bit was unchecked by ojan@chromium.org
6 years, 6 months ago (2014-05-27 22:32:27 UTC) #6
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 6 months ago (2014-05-27 22:32:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/306453006/1
6 years, 6 months ago (2014-05-27 22:33:08 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-28 00:24:56 UTC) #9
Message was sent while issue was closed.
Change committed as 174914

Powered by Google App Engine
This is Rietveld 408576698