Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/atomicops_internals_x86_gcc.cc

Issue 306453005: Replace some calls to MemCopy with small constant sizes with memcpy (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/conversions-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This module gets enough CPU information to optimize the 5 // This module gets enough CPU information to optimize the
6 // atomicops module on x86. 6 // atomicops module on x86.
7 7
8 #include <string.h> 8 #include <string.h>
9 9
10 #include "atomicops.h" 10 #include "atomicops.h"
11 #include "utils.h"
12 11
13 // This file only makes sense with atomicops_internals_x86_gcc.h -- it 12 // This file only makes sense with atomicops_internals_x86_gcc.h -- it
14 // depends on structs that are defined in that file. If atomicops.h 13 // depends on structs that are defined in that file. If atomicops.h
15 // doesn't sub-include that file, then we aren't needed, and shouldn't 14 // doesn't sub-include that file, then we aren't needed, and shouldn't
16 // try to do anything. 15 // try to do anything.
17 #ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_ 16 #ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_
18 17
19 // Inline cpuid instruction. In PIC compilations, %ebx contains the address 18 // Inline cpuid instruction. In PIC compilations, %ebx contains the address
20 // of the global offset table. To avoid breaking such executables, this code 19 // of the global offset table. To avoid breaking such executables, this code
21 // must preserve that register's value across cpuid instructions. 20 // must preserve that register's value across cpuid instructions.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 using v8::internal::AtomicOps_Internalx86CPUFeatures; 54 using v8::internal::AtomicOps_Internalx86CPUFeatures;
56 55
57 uint32_t eax = 0; 56 uint32_t eax = 0;
58 uint32_t ebx = 0; 57 uint32_t ebx = 0;
59 uint32_t ecx = 0; 58 uint32_t ecx = 0;
60 uint32_t edx = 0; 59 uint32_t edx = 0;
61 60
62 // Get vendor string (issue CPUID with eax = 0) 61 // Get vendor string (issue CPUID with eax = 0)
63 cpuid(eax, ebx, ecx, edx, 0); 62 cpuid(eax, ebx, ecx, edx, 0);
64 char vendor[13]; 63 char vendor[13];
65 v8::internal::MemCopy(vendor, &ebx, 4); 64 memcpy(vendor, &ebx, 4);
66 v8::internal::MemCopy(vendor + 4, &edx, 4); 65 memcpy(vendor + 4, &edx, 4);
67 v8::internal::MemCopy(vendor + 8, &ecx, 4); 66 memcpy(vendor + 8, &ecx, 4);
68 vendor[12] = 0; 67 vendor[12] = 0;
69 68
70 // get feature flags in ecx/edx, and family/model in eax 69 // get feature flags in ecx/edx, and family/model in eax
71 cpuid(eax, ebx, ecx, edx, 1); 70 cpuid(eax, ebx, ecx, edx, 1);
72 71
73 int family = (eax >> 8) & 0xf; // family and model fields 72 int family = (eax >> 8) & 0xf; // family and model fields
74 int model = (eax >> 4) & 0xf; 73 int model = (eax >> 4) & 0xf;
75 if (family == 0xf) { // use extended family and model fields 74 if (family == 0xf) { // use extended family and model fields
76 family += (eax >> 20) & 0xff; 75 family += (eax >> 20) & 0xff;
77 model += ((eax >> 16) & 0xf) << 4; 76 model += ((eax >> 16) & 0xf) << 4;
(...skipping 25 matching lines...) Expand all
103 102
104 103
105 // A global to get use initialized on startup via static initialization :/ 104 // A global to get use initialized on startup via static initialization :/
106 AtomicOpsx86Initializer g_initer; 105 AtomicOpsx86Initializer g_initer;
107 106
108 } // namespace 107 } // namespace
109 108
110 #endif // if x86 109 #endif // if x86
111 110
112 #endif // ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_ 111 #endif // ifdef V8_ATOMICOPS_INTERNALS_X86_GCC_H_
OLDNEW
« no previous file with comments | « src/arm/simulator-arm.cc ('k') | src/conversions-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698