Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 306453003: Remove apk-codegen.xml (Closed)

Created:
6 years, 6 months ago by cjhopman
Modified:
6 years, 6 months ago
Reviewers:
Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove apk-codegen.xml process_resources.py already implements almost everything from apk-codegen.xml so just use that instead. BUG=359249, 375324, 375431 TBR=yfriedman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272928

Patch Set 1 #

Patch Set 2 : Fix proguard.txt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -167 lines) Patch
D build/android/ant/apk-codegen.xml View 1 chunk +0 lines, -98 lines 0 comments Download
M build/android/ant/apk-obfuscate.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M build/android/ant/apk-package-resources.xml View 3 chunks +3 lines, -29 lines 0 comments Download
M build/android/gyp/process_resources.py View 1 4 chunks +64 lines, -8 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 chunk +1 line, -1 line 0 comments Download
M build/java.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M build/java_apk.gypi View 1 3 chunks +29 lines, -26 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
cjhopman
TBRed yfriedman for *
6 years, 6 months ago (2014-05-26 23:36:20 UTC) #1
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-05-26 23:36:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/306453003/20001
6 years, 6 months ago (2014-05-26 23:37:20 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 6 months ago (2014-05-27 02:49:33 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-27 05:42:51 UTC) #5
Message was sent while issue was closed.
Change committed as 272928

Powered by Google App Engine
This is Rietveld 408576698